commit 10cf5c7317c56b16088f9c6509c3be1740bd15a4
author Vitaly Buka <vitalybuka@chromium.org> Wed Apr 29 12:05:10 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Thu Apr 30 01:28:37 2015 +0000
tree 8d73b2a5cfbe904550f684545ddc0e43dabe0036
parent 5f0d1d0681c8f167d34e86921043d348ae2fcf51

buffet: Allow omitting "parameters" and "results"

Many commands have neither parameters nor results.
Empty schema will be used if if section is omitted in command definition.

BUG=brillo:915
TEST=FEATURES=test emerge-gizmo buffet

Change-Id: I4df542d889f325223a436bfe032950aa05c35b6e
Reviewed-on: https://chromium-review.googlesource.com/268317
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>

buffet/commands/command_dictionary.cc

diff --git a/buffet/commands/command_dictionary.cc b/buffet/commands/command_dictionary.cc
index 3ab57a5..cbfd46b 100644
--- a/buffet/commands/command_dictionary.cc
+++ b/buffet/commands/command_dictionary.cc
@@ -173,13 +173,7 @@
   const base::DictionaryValue* schema_def = nullptr;
   if (!command_def_json->GetDictionaryWithoutPathExpansion(property_name,
                                                            &schema_def)) {
-    chromeos::Error::AddToPrintf(
-        error, FROM_HERE, errors::commands::kDomain,
-        errors::commands::kPropertyMissing,
-        "Command definition '%s' is missing property '%s'",
-        command_name.c_str(),
-        property_name);
-    return {};
+    return object_schema;
   }
 
   if (!object_schema->FromJson(schema_def, base_def, error)) {