commit 1a108717d3d6ac17974b835dc18f6c177fb609ff
author Vitaly Buka <vitalybuka@google.com> Sun Dec 06 17:41:07 2015 -0800
committer Vitaly Buka <vitalybuka@google.com> Tue Dec 08 01:01:54 2015 +0000
tree 20a57ba7727c174cf29c6ed7675123091777cfa9
parent a580328ad41e1377431367d935a1e6ea71b1a892

Remove output error parameter from BuildDeviceResource

This method never fails.

Change-Id: If7c385f967e943172fa97e98c2c1c4e18a5cdc8f
Reviewed-on: https://weave-review.googlesource.com/1798
Reviewed-by: Alex Vakulenko <avakulenko@google.com>

src/device_registration_info.cc

diff --git a/src/device_registration_info.cc b/src/device_registration_info.cc
index abdbb08..3bc7515 100644
--- a/src/device_registration_info.cc
+++ b/src/device_registration_info.cc
@@ -477,7 +477,7 @@
 }
 
 std::unique_ptr<base::DictionaryValue>
-DeviceRegistrationInfo::BuildDeviceResource(ErrorPtr* error) {
+DeviceRegistrationInfo::BuildDeviceResource() const {
   std::unique_ptr<base::DictionaryValue> resource{new base::DictionaryValue};
   if (!GetSettings().cloud_id.empty())
     resource->SetString("id", GetSettings().cloud_id);
@@ -521,11 +521,8 @@
 
 void DeviceRegistrationInfo::RegisterDevice(const std::string& ticket_id,
                                             const DoneCallback& callback) {
-  ErrorPtr error;
-  std::unique_ptr<base::DictionaryValue> device_draft =
-      BuildDeviceResource(&error);
-  if (!device_draft)
-    return RegisterDeviceError(callback, std::move(error));
+  std::unique_ptr<base::DictionaryValue> device_draft = BuildDeviceResource();
+  CHECK(device_draft);
 
   base::DictionaryValue req_json;
   req_json.SetString("id", ticket_id);
@@ -897,12 +894,9 @@
   queued_resource_update_callbacks_.clear();
 
   VLOG(1) << "Updating GCD server with CDD...";
-  ErrorPtr error;
   std::unique_ptr<base::DictionaryValue> device_resource =
-      BuildDeviceResource(&error);
-  if (!device_resource) {
-    return OnUpdateDeviceResourceError(std::move(error));
-  }
+      BuildDeviceResource();
+  CHECK(device_resource);
 
   std::string url = GetDeviceURL(
       {}, {{"lastUpdateTimeMs", last_device_resource_updated_timestamp_}});

src/device_registration_info.h

diff --git a/src/device_registration_info.h b/src/device_registration_info.h
index f3b5302..ff9c29b 100644
--- a/src/device_registration_info.h
+++ b/src/device_registration_info.h
@@ -247,7 +247,7 @@
   // Builds Cloud API devices collection REST resource which matches
   // current state of the device including command definitions
   // for all supported commands and current device state.
-  std::unique_ptr<base::DictionaryValue> BuildDeviceResource(ErrorPtr* error);
+  std::unique_ptr<base::DictionaryValue> BuildDeviceResource() const;
 
   void SetGcdState(GcdState new_state);
   void SetDeviceId(const std::string& cloud_id);