)]}'
{
  "commit": "26f557b524b63b72e4828e52f923d09ed184fffd",
  "tree": "cab0ce0514e1469a82e999da9946f3f918995db9",
  "parents": [
    "e968f06d5a04cca85948d7c5bf750f41eb746db8"
  ],
  "author": {
    "name": "Alex Vakulenko",
    "email": "avakulenko@chromium.org",
    "time": "Tue May 26 16:47:40 2015 -0700"
  },
  "committer": {
    "name": "ChromeOS Commit Bot",
    "email": "chromeos-commit-bot@chromium.org",
    "time": "Wed May 27 02:39:42 2015 +0000"
  },
  "message": "buffet: XMPP channel sockets are left behind unclosed\n\nWhen an XMPP channel is closed the underlying TCP socket isn\u0027t closed\nproperly.\n\nThe main problem is that when we reset the connection, we do not call\nNotificationChannel::Stop() to close the underlying socket. However,\nchromeos::FileStream also fails to close the file descriptor in case\nwhen Stream::Close wasn\u0027t called explicitly. And TlsStream wasn\u0027t\nclosing TLS session automatically if Stream::Close hasn\u0027t been called\nmanually. In all fairness, a stream should be closed manually, since\nthis is the only way to process possible errors on close, but still\nwe should not leak resources (like file descriptors) if the Close\nhasn\u0027t been called and a stream is destroyed.\n\nBUG\u003dbrillo:1134\nTEST\u003d`FEATURES\u003dtest emerge-link libchromeos buffet`\n\nChange-Id: Ic71a883bc6e9e51a49249c79b4106efd0520ab68\nReviewed-on: https://chromium-review.googlesource.com/273346\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nReviewed-by: Vitaly Buka \u003cvitalybuka@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "34358810ce6d18d518bd3f0436f64323b84bb490",
      "old_mode": 33188,
      "old_path": "buffet/device_registration_info.cc",
      "new_id": "f31495cc1b61be114e94c5e14c74033cabd38f71",
      "new_mode": 33188,
      "new_path": "buffet/device_registration_info.cc"
    },
    {
      "type": "modify",
      "old_id": "4afb5df2fdc51fe86a45daa94d585004dfa8e113",
      "old_mode": 33188,
      "old_path": "buffet/notification/xmpp_channel.h",
      "new_id": "73daee3289fba17c8c20a50e26865737f1b03229",
      "new_mode": 33188,
      "new_path": "buffet/notification/xmpp_channel.h"
    }
  ]
}