Fix some of compiler warnings.

Also re-enabled redundant warnings that no-longer occur in code.

Change-Id: I900cf1d732f96aaad40bee2b6da52fe43889331a
Reviewed-on: https://weave-review.googlesource.com/2732
Reviewed-by: Alex Vakulenko <avakulenko@google.com>

Makefile

diff --git a/Makefile b/Makefile
index 9810dd0..70f7ee7 100644
--- a/Makefile
+++ b/Makefile
@@ -28,13 +28,8 @@
 	-Wextra \
 	-Wformat=2 \
 	-Wl,--exclude-libs,ALL \
-	-Wno-char-subscripts \
 	-Wno-missing-field-initializers \
-	-Wno-unused-local-typedefs \
 	-Wno-unused-parameter \
-	-Wpacked \
-	-Wpointer-arith \
-	-Wwrite-strings
 
 CFLAGS_Debug := \
 	-O0 \
@@ -56,7 +51,6 @@
   CFLAGS := $(filter-out -Wl$(comma)--exclude-libs$(comma)ALL,$(CFLAGS))
   CFLAGS += \
     -fno-omit-frame-pointer \
-    -Wno-deprecated-register \
     -Wno-inconsistent-missing-override
   ifeq (Debug, $(BUILD_MODE))
     CFLAGS += \

third_party/chromium/base/third_party/dmg_fp/dtoa.cc

diff --git a/third_party/chromium/base/third_party/dmg_fp/dtoa.cc b/third_party/chromium/base/third_party/dmg_fp/dtoa.cc
index 502c16c..c06219c 100644
--- a/third_party/chromium/base/third_party/dmg_fp/dtoa.cc
+++ b/third_party/chromium/base/third_party/dmg_fp/dtoa.cc
@@ -59,6 +59,7 @@
  *	4. Because of 3., we don't need a large table of powers of 10
  *		for ten-to-e (just some small tables, e.g. of 10^k
  *		for 0 <= k <= 22).
+ *	5. Fixed -Wchar-subscripts warning in "if (!hexdig['0'])"
  */
 
 /*
@@ -1572,7 +1573,7 @@
 	CONST char *s;
 	int c1, havedig, udx0, xshift;
 
-	if (!hexdig['0'])
+	if (!hexdig[0 + '0'])
 		hexdig_init();
 	x[0] = x[1] = 0;
 	havedig = xshift = 0;

third_party/chromium/base/third_party/dmg_fp/g_fmt.cc

diff --git a/third_party/chromium/base/third_party/dmg_fp/g_fmt.cc b/third_party/chromium/base/third_party/dmg_fp/g_fmt.cc
index bfa358d..67c9f57 100644
--- a/third_party/chromium/base/third_party/dmg_fp/g_fmt.cc
+++ b/third_party/chromium/base/third_party/dmg_fp/g_fmt.cc
@@ -27,10 +27,10 @@
 namespace dmg_fp {
 
  char *
-g_fmt(register char *b, double x)
+g_fmt(char *b, double x)
 {
-	register int i, k;
-	register char *s;
+	int i, k;
+	char *s;
 	int decpt, j, sign;
 	char *b0, *s0, *se;