commit 5191e81a2a81aaf57acea001a9c45b5186604bbc
author Anton Muhin <antonm@google.com> Thu Oct 30 17:49:48 2014 +0400
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Nov 07 06:34:01 2014 +0000
tree 0ad36854415e650efafb83d23096699ef48e341b
parent 5c7bf01d22935ebf669aa85a615923ebc420c1a9

buffet: Separate command IDs from DBus paths.

As we're starting to support cloud and local cases, we need proper
support for cloud command IDs.  Therefore now we require each
command instance to have some command id, but generate dbus path
independently.

BUG=None
TEST=cros_workon_make buffet --test&&manual

Change-Id: I83ae92872d920c8e0d6e15324ad11feebfd1f540
Reviewed-on: https://chromium-review.googlesource.com/226532
Tested-by: Anton Muhin <antonm@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Anton Muhin <antonm@chromium.org>

buffet/device_registration_info.cc

diff --git a/buffet/device_registration_info.cc b/buffet/device_registration_info.cc
index 30c62a9..b925033 100644
--- a/buffet/device_registration_info.cc
+++ b/buffet/device_registration_info.cc
@@ -140,8 +140,11 @@
   return chromeos::url::AppendQueryParams(result, params);
 }
 
-auto ignore_cloud_error = base::Bind([](const chromeos::Error&){});
-auto ignore_cloud_result = base::Bind([](const base::DictionaryValue&){});
+void IgnoreCloudError(const chromeos::Error&) {
+}
+
+void IgnoreCloudResult(const base::DictionaryValue&) {
+}
 
 }  // anonymous namespace
 
@@ -662,7 +665,7 @@
       }),
       // TODO(antonm): Failure to update device resource probably deserves
       // some additional actions.
-      ignore_cloud_error);
+      base::Bind(&IgnoreCloudError));
 }
 
 void DeviceRegistrationInfo::FetchCommands(
@@ -679,7 +682,7 @@
         const base::ListValue empty;
         callback.Run(commands ? *commands : empty);
       }),
-      ignore_cloud_error);
+      base::Bind(&IgnoreCloudError));
 }
 
 void DeviceRegistrationInfo::AbortLimboCommands(
@@ -714,7 +717,7 @@
         chromeos::http::request_type::kPut,
         GetServiceURL("commands/" + command_id),
         command_copy.get(),
-        ignore_cloud_result, ignore_cloud_error);
+        base::Bind(&IgnoreCloudResult), base::Bind(&IgnoreCloudError));
   }
 
   base::MessageLoop::current()->PostTask(FROM_HERE, callback);
@@ -751,9 +754,9 @@
       continue;
     }
 
-    // TODO(antonm): Double check if there is a chance to publish
-    // the same command twice if it doesn't change its status.
-    command_manager_->AddCommand(std::move(command_instance));
+    // TODO(antonm): Properly process cancellation of commands.
+    if (!command_manager_->FindCommand(command_instance->GetID()))
+      command_manager_->AddCommand(std::move(command_instance));
   }
 }