commit 5a9e718e5299c72094d1bcfd988d7e44831e9d07
author Alex Vakulenko <avakulenko@chromium.org> Mon Aug 11 15:59:58 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Tue Aug 12 23:10:06 2014 +0000
tree 6d4b31b79ff40484a77e111bfe9f7863f8ef7c6e
parent e23caf25571af9ca44bf7f2b9e2d06a66d515100

platform2: sweep the lint errors identified by the updated linter

cpplint.py has been updated and identified new issues in existing
code. Stuff like overridden functions that specify 'override' should
not be marked as 'virtual', and constructors with no parameters
should not be marked as 'explicit'.

BUG=None
TEST=cpplint.py `find ./platform2 -name *.cc -or -name *.h`

Change-Id: Ibb9de43286d874d076ffd5ebb1b13c36ec794f01
Reviewed-on: https://chromium-review.googlesource.com/211950
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>

buffet/commands/prop_constraints.h

diff --git a/buffet/commands/prop_constraints.h b/buffet/commands/prop_constraints.h
index da43e86..cd35d65 100644
--- a/buffet/commands/prop_constraints.h
+++ b/buffet/commands/prop_constraints.h
@@ -96,12 +96,12 @@
       : limit_(limit) {}
 
   // Implementation of Constraint::HasOverriddenAttributes().
-  virtual bool HasOverriddenAttributes() const override {
+  bool HasOverriddenAttributes() const override {
     return !limit_.is_inherited;
   }
 
   // Implementation of Constraint::ToJson().
-  virtual std::unique_ptr<base::Value> ToJson(ErrorPtr* error) const override {
+  std::unique_ptr<base::Value> ToJson(ErrorPtr* error) const override {
     return TypedValueToJson(limit_.value, error);
   }
 
@@ -124,11 +124,10 @@
       : ConstraintMinMaxBase<T>(limit) {}
 
   // Implementation of Constraint::GetType().
-  virtual ConstraintType GetType() const { return ConstraintType::Min; }
+  ConstraintType GetType() const { return ConstraintType::Min; }
 
   // Implementation of Constraint::Validate().
-  virtual bool Validate(const PropValue& value,
-                        ErrorPtr* error) const override {
+  bool Validate(const PropValue& value, ErrorPtr* error) const override {
     T v = value.GetValueAsAny().Get<T>();
     if (v < this->limit_.value)
       return this->ReportErrorLessThan(
@@ -138,12 +137,12 @@
   }
 
   // Implementation of Constraint::CloneAsInherited().
-  virtual std::shared_ptr<Constraint> CloneAsInherited() const override {
+  std::shared_ptr<Constraint> CloneAsInherited() const override {
     return std::make_shared<ConstraintMin>(this->limit_.value);
   }
 
   // Implementation of Constraint::GetDictKey().
-  virtual const char* GetDictKey() const override {
+  const char* GetDictKey() const override {
     return commands::attributes::kNumeric_Min;
   }
 
@@ -161,11 +160,10 @@
       : ConstraintMinMaxBase<T>(limit) {}
 
   // Implementation of Constraint::GetType().
-  virtual ConstraintType GetType() const { return ConstraintType::Max; }
+  ConstraintType GetType() const { return ConstraintType::Max; }
 
   // Implementation of Constraint::Validate().
-  virtual bool Validate(const PropValue& value,
-                        ErrorPtr* error) const override {
+  bool Validate(const PropValue& value, ErrorPtr* error) const override {
     T v = value.GetValueAsAny().Get<T>();
     if (v > this->limit_.value)
       return this->ReportErrorGreaterThan(
@@ -175,12 +173,12 @@
   }
 
   // Implementation of Constraint::CloneAsInherited().
-  virtual std::shared_ptr<Constraint> CloneAsInherited() const override {
+  std::shared_ptr<Constraint> CloneAsInherited() const override {
     return std::make_shared<ConstraintMax>(this->limit_.value);
   }
 
   // Implementation of Constraint::GetDictKey().
-  virtual const char* GetDictKey() const override {
+  const char* GetDictKey() const override {
     return commands::attributes::kNumeric_Max;
   }
 
@@ -196,9 +194,9 @@
   explicit ConstraintStringLength(int limit);
 
   // Implementation of Constraint::HasOverriddenAttributes().
-  virtual bool HasOverriddenAttributes() const override;
+  bool HasOverriddenAttributes() const override;
   // Implementation of Constraint::ToJson().
-  virtual std::unique_ptr<base::Value> ToJson(ErrorPtr* error) const override;
+  std::unique_ptr<base::Value> ToJson(ErrorPtr* error) const override;
 
   // Stores the upper/lower value limit for string length constraint.
   // |limit_.is_inherited| indicates whether the constraint is inherited
@@ -215,15 +213,15 @@
   explicit ConstraintStringLengthMin(const InheritableAttribute<int>& limit);
   explicit ConstraintStringLengthMin(int limit);
   // Implementation of Constraint::GetType().
-  virtual ConstraintType GetType() const override {
+  ConstraintType GetType() const override {
     return ConstraintType::StringLengthMin;
   }
   // Implementation of Constraint::Validate().
-  virtual bool Validate(const PropValue& value, ErrorPtr* error) const override;
+  bool Validate(const PropValue& value, ErrorPtr* error) const override;
   // Implementation of Constraint::CloneAsInherited().
-  virtual std::shared_ptr<Constraint> CloneAsInherited() const override;
+  std::shared_ptr<Constraint> CloneAsInherited() const override;
   // Implementation of Constraint::GetDictKey().
-  virtual const char* GetDictKey() const override {
+  const char* GetDictKey() const override {
     return commands::attributes::kString_MinLength;
   }
  private:
@@ -236,15 +234,15 @@
   explicit ConstraintStringLengthMax(const InheritableAttribute<int>& limit);
   explicit ConstraintStringLengthMax(int limit);
   // Implementation of Constraint::GetType().
-  virtual ConstraintType GetType() const override {
+  ConstraintType GetType() const override {
     return ConstraintType::StringLengthMax;
   }
   // Implementation of Constraint::Validate().
-  virtual bool Validate(const PropValue& value, ErrorPtr* error) const override;
+  bool Validate(const PropValue& value, ErrorPtr* error) const override;
   // Implementation of Constraint::CloneAsInherited().
-  virtual std::shared_ptr<Constraint> CloneAsInherited() const override;
+  std::shared_ptr<Constraint> CloneAsInherited() const override;
   // Implementation of Constraint::GetDictKey().
-  virtual const char* GetDictKey() const override {
+  const char* GetDictKey() const override {
     return commands::attributes::kString_MaxLength;
   }
 
@@ -262,18 +260,17 @@
       : set_(set) {}
 
   // Implementation of Constraint::GetType().
-  virtual ConstraintType GetType() const override {
+  ConstraintType GetType() const override {
     return ConstraintType::OneOf;
   }
 
   // Implementation of Constraint::HasOverriddenAttributes().
-  virtual bool HasOverriddenAttributes() const override {
+  bool HasOverriddenAttributes() const override {
     return !set_.is_inherited;
   }
 
   // Implementation of Constraint::Validate().
-  virtual bool Validate(const PropValue& value,
-                        ErrorPtr* error) const override {
+  bool Validate(const PropValue& value, ErrorPtr* error) const override {
     using string_utils::ToString;
     T v = value.GetValueAsAny().Get<T>();
     for (const auto& item : set_.value) {
@@ -289,17 +286,17 @@
   }
 
   // Implementation of Constraint::CloneAsInherited().
-  virtual std::shared_ptr<Constraint> CloneAsInherited() const override {
+  std::shared_ptr<Constraint> CloneAsInherited() const override {
     return std::make_shared<ConstraintOneOf>(set_.value);
   }
 
   // Implementation of Constraint::ToJson().
-  virtual std::unique_ptr<base::Value> ToJson(ErrorPtr* error) const override {
+  std::unique_ptr<base::Value> ToJson(ErrorPtr* error) const override {
     return TypedValueToJson(set_.value, error);
   }
 
   // Implementation of Constraint::GetDictKey().
-  virtual const char* GetDictKey() const override {
+  const char* GetDictKey() const override {
     return commands::attributes::kOneOf_Enum;
   }