buffet: Remove initial OnRegistrationStatusChanged call
This call was neccecary because DeviceRegistrationInfo calls callback only
if values actually changed, skipping callback for intial value. We still need to
call callback there too. Solved by additional stus change in Load().
Also some reformating and renames.
BUG=brillo:592
TEST=covered by buffet_Registration
Change-Id: Iafa8e5b1eac342a99c54c3c067a742182221186f
Reviewed-on: https://chromium-review.googlesource.com/261589
Tested-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
diff --git a/buffet/device_registration_info.h b/buffet/device_registration_info.h
index c519048..f985d42 100644
--- a/buffet/device_registration_info.h
+++ b/buffet/device_registration_info.h
@@ -45,7 +45,6 @@
public:
// This is a helper class for unit testing.
class TestHelper;
- using StatusHandler = base::Closure;
DeviceRegistrationInfo(
const std::shared_ptr<CommandManager>& command_manager,
@@ -53,7 +52,7 @@
std::unique_ptr<chromeos::KeyValueStore> config_store,
const std::shared_ptr<chromeos::http::Transport>& transport,
const std::shared_ptr<StorageInterface>& state_store,
- const StatusHandler& status_handler);
+ const base::Closure& on_status_changed);
~DeviceRegistrationInfo() override;
@@ -256,7 +255,7 @@
// Tracks our current registration status.
RegistrationStatus registration_status_{RegistrationStatus::kUnconfigured};
- StatusHandler registration_status_handler_;
+ base::Closure on_status_changed_;
friend class TestHelper;
base::WeakPtrFactory<DeviceRegistrationInfo> weak_factory_{this};