commit 9945fac1c0e29a92fda3e0bc9734b6cd96b7c373
author Anton Muhin <antonm@google.com> Wed Oct 22 11:03:23 2014 +0400
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Oct 22 19:44:03 2014 +0000
tree 30babd37f6032a7e823192d817fcbe9ac67eaa23
parent 9e19cdd271e2894c48ec1777bfffc19f5b109462

buffet: Better access to JSON properies.

We should be checking the return value of the getters to detect
failures instead of relying on the value of the out arguments.

BUG=None
TEST=cros_workon_make buffet --test&&manual

Change-Id: I93118ae659600af4017b4925dd0b8ec4bf14f4d8
Reviewed-on: https://chromium-review.googlesource.com/224930
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Anton Muhin <antonm@chromium.org>
Commit-Queue: Anton Muhin <antonm@chromium.org>
Tested-by: Anton Muhin <antonm@chromium.org>

buffet/device_registration_info.cc

diff --git a/buffet/device_registration_info.cc b/buffet/device_registration_info.cc
index 30cbb93..21638e8 100644
--- a/buffet/device_registration_info.cc
+++ b/buffet/device_registration_info.cc
@@ -629,19 +629,16 @@
 
   auto abort_commands_cb = [] (const base::DictionaryValue& json) {
     const base::ListValue* commands{nullptr};
-    json.GetList("commands", &commands);
-    if (commands) {
+    if (json.GetList("commands", &commands)) {
       const size_t size{commands->GetSize()};
       for (size_t i = 0; i < size; ++i) {
         const base::DictionaryValue* command{nullptr};
-        commands->GetDictionary(i, &command);
-        if (!command) {
+        if (!commands->GetDictionary(i, &command)) {
           LOG(WARNING) << "No command resource at " << i;
           continue;
         }
         std::string command_state;
-        command->GetString("state", &command_state);
-        if (command_state.empty()) {
+        if (!command->GetString("state", &command_state)) {
           LOG(WARNING) << "Command with no state at " << i;
           continue;
         }
@@ -652,8 +649,7 @@
           continue;
         }
         std::string command_id;
-        command->GetString("id", &command_id);
-        if (command_id.empty()) {
+        if (!command->GetString("id", &command_id)) {
           LOG(WARNING) << "Command with no ID at " << i;
           continue;
         }