commit 9e2f8cda5fb177d7dc8d43011eea3829427e34cd
author Alex Vakulenko <avakulenko@chromium.org> Tue Apr 07 16:28:09 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Wed Apr 08 03:44:08 2015 +0000
tree 3a767d1ad5c2b8eb1d02f0d031d1f1f6e8417658
parent d732bd0c60802394484894035fa3f21505382823

buffet: Fix crash when CommandInstance::SetResults() is invoked

The crash was a result of use-after-delete in
CloudCommandProxy::OnResultsChanged() where TypedValueToJson returned
std::unique_ptr while the JSON value was set to Dictionary by using
unique_ptr::get() on the temporary. Should have called release()
instead to transfer the ownership to the dictionary.

Added a unit test to buffet/device_registration_info_unittest.cc to
test this specific scenario.

BUG=brillo:770
TEST=`FEATURES=test emerge-link buffet`

Change-Id: I34a28ce610a06f2b77af1cc75e358b3fb3562a13
Reviewed-on: https://chromium-review.googlesource.com/264465
Trybot-Ready: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

buffet/commands/command_manager.cc

diff --git a/buffet/commands/command_manager.cc b/buffet/commands/command_manager.cc
index afdd518..f7533ca 100644
--- a/buffet/commands/command_manager.cc
+++ b/buffet/commands/command_manager.cc
@@ -26,6 +26,10 @@
   command_queue_.SetCommandDispachInterface(&command_dispatcher_);
 }
 
+CommandManager::CommandManager(CommandDispachInterface* dispatch_interface) {
+  command_queue_.SetCommandDispachInterface(dispatch_interface);
+}
+
 const CommandDictionary& CommandManager::GetCommandDictionary() const {
   return dictionary_;
 }