commit a0424dd2a55180d75453b267680cb3738379d4db
author Alex Vakulenko <avakulenko@chromium.org> Fri Jun 13 16:10:17 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Mon Jun 16 21:45:28 2014 +0000
tree cbca85823f06389095ae8eb123bcadf53d495ad7
parent e439a0f9d6453121dc21b9d557f6983ef2352513

buffet: remove unnecessary NOLINTs and restored some C++11 code

The old cpplint was issuing a lot of false-positives for new C++11
features and I had to either explicitly disable the warning or
work around them (e.g. instead of using uniform initialization,
I used a normal constructor syntax with initializer list inside).

These redundancies are no longer needed since the linter has been
updated.

Also removed some of auto&& from loops because the new
cpplint complains about RValue references.

BUG=None
TEST=Unit tests still pass.

Change-Id: Ibe9538e3e1cb793be807a23e82627444e663934c
Reviewed-on: https://chromium-review.googlesource.com/203797
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

buffet/any_unittest.cc

diff --git a/buffet/any_unittest.cc b/buffet/any_unittest.cc
index 48df826..eaf3ce1 100644
--- a/buffet/any_unittest.cc
+++ b/buffet/any_unittest.cc
@@ -73,7 +73,7 @@
   val2.Clear();
   EXPECT_TRUE(val2.IsEmpty());
 
-  val = std::vector<int>({100, 20, 3});
+  val = std::vector<int>{100, 20, 3};
   auto v = val.Get<std::vector<int>>();
   EXPECT_EQ(100, v[0]);
   EXPECT_EQ(20, v[1]);
@@ -197,7 +197,7 @@
     std::string name;
     int age;
   };
-  Any val(Person{"Jack", 40});  // NOLINT(whitespace/braces)
+  Any val(Person{"Jack", 40});
   Any val2 = val;
   EXPECT_EQ("Jack", val.Get<Person>().name);
   val.GetPtr<Person>()->name = "Joe";