buffet: remove unnecessary NOLINTs and restored some C++11 code
The old cpplint was issuing a lot of false-positives for new C++11
features and I had to either explicitly disable the warning or
work around them (e.g. instead of using uniform initialization,
I used a normal constructor syntax with initializer list inside).
These redundancies are no longer needed since the linter has been
updated.
Also removed some of auto&& from loops because the new
cpplint complains about RValue references.
BUG=None
TEST=Unit tests still pass.
Change-Id: Ibe9538e3e1cb793be807a23e82627444e663934c
Reviewed-on: https://chromium-review.googlesource.com/203797
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/buffet/mime_utils.cc b/buffet/mime_utils.cc
index ca221dc..dc57497 100644
--- a/buffet/mime_utils.cc
+++ b/buffet/mime_utils.cc
@@ -102,7 +102,7 @@
const mime::Parameters& parameters) {
std::vector<std::string> parts;
parts.push_back(string_utils::Join('/', type, subtype));
- for (auto&& pair : parameters) {
+ for (const auto& pair : parameters) {
parts.push_back(string_utils::Join('=', pair.first,
EncodeParam(pair.second)));
}
@@ -146,7 +146,7 @@
std::string mime::GetParameterValue(const std::string& mime_string,
const std::string& paramName) {
mime::Parameters params = mime::GetParameters(mime_string);
- for (auto&& pair : params) {
+ for (const auto& pair : params) {
if (base::strcasecmp(pair.first.c_str(), paramName.c_str()) == 0)
return pair.second;
}
