commit a0424dd2a55180d75453b267680cb3738379d4db
author Alex Vakulenko <avakulenko@chromium.org> Fri Jun 13 16:10:17 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Mon Jun 16 21:45:28 2014 +0000
tree cbca85823f06389095ae8eb123bcadf53d495ad7
parent e439a0f9d6453121dc21b9d557f6983ef2352513

buffet: remove unnecessary NOLINTs and restored some C++11 code

The old cpplint was issuing a lot of false-positives for new C++11
features and I had to either explicitly disable the warning or
work around them (e.g. instead of using uniform initialization,
I used a normal constructor syntax with initializer list inside).

These redundancies are no longer needed since the linter has been
updated.

Also removed some of auto&& from loops because the new
cpplint complains about RValue references.

BUG=None
TEST=Unit tests still pass.

Change-Id: Ibe9538e3e1cb793be807a23e82627444e663934c
Reviewed-on: https://chromium-review.googlesource.com/203797
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

buffet/url_utils.cc

diff --git a/buffet/url_utils.cc b/buffet/url_utils.cc
index 0395094..3fcdb48 100644
--- a/buffet/url_utils.cc
+++ b/buffet/url_utils.cc
@@ -71,7 +71,7 @@
   std::string result = url;
   if (!parts.empty()) {
     std::string query_string = TrimOffQueryString(&result);
-    for (auto&& part : parts) {
+    for (const auto& part : parts) {
       if (!part.empty()) {
         if (!result.empty() && result.back() != '/')
           result += '/';
@@ -112,7 +112,7 @@
 std::string url::GetQueryStringValue(
     const data_encoding::WebParamList& params,
     const std::string& name) {
-  for (auto&& pair : params) {
+  for (const auto& pair : params) {
     if (name.compare(pair.first) == 0)
       return pair.second;
   }