commit a3062c51e29efac97c51272b2b7d8b6b9fd593c1
author Alex Vakulenko <avakulenko@chromium.org> Mon Apr 21 17:05:51 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Thu Apr 24 21:58:14 2014 +0000
tree 75098be8065b89ba11b9ff69bc4112f8f09c53bb
parent bda220ae043637838e0570d4eb695b4f6b818c06

buffet: reworked http transport to prepare for unit testing

Changed the way HTTP transport classes are implemented. Now
the Transport class is a very simple factory class that just
creates an appropriate instance of http::Connection object.
http::Connection is a thin layer wrapper around underlying
transport library, such as libcurl.

Also, the Transport class is now stateless and can be used
to initiate multiple HTTP connections.

Majority of HTTP processing is done in http::Request and
http::Response classes which are not dependent on the underlying
transport.

The HTTP utility functions now take the Transport class as
a parameter to facilitate unit tesing.

Also added a stub http_utils_unittest.cc to be populated
with actual tests when the fake HTTP transport is implemented.

BUG=chromium:364733
TEST=Unit tests pass.

Change-Id: If506854d274f725bbc2d6f765f19344d8697a239
Reviewed-on: https://chromium-review.googlesource.com/196153
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

buffet/device_registration_info.h

diff --git a/buffet/device_registration_info.h b/buffet/device_registration_info.h
index 88a655b..6eea8eb 100644
--- a/buffet/device_registration_info.h
+++ b/buffet/device_registration_info.h
@@ -5,13 +5,15 @@
 #ifndef BUFFET_DEVICE_INFO_H_
 #define BUFFET_DEVICE_INFO_H_
 
-#include <base/basictypes.h>
-#include <base/time/time.h>
 #include <string>
 #include <map>
 #include <memory>
 
+#include <base/basictypes.h>
+#include <base/time/time.h>
+
 #include "buffet/data_encoding.h"
+#include "buffet/http_transport.h"
 
 namespace base {
   class Value;
@@ -22,7 +24,11 @@
 // The DeviceRegistrationInfo class represents device registration information.
   class DeviceRegistrationInfo {
  public:
-   DeviceRegistrationInfo() = default;
+   // Default-constructed uses CURL HTTP transport.
+   DeviceRegistrationInfo();
+   // This constructor allows to pass in a custom HTTP transport
+   // (mainly for testing).
+   DeviceRegistrationInfo(std::shared_ptr<chromeos::http::Transport> transport);
 
   // Returns the authorization HTTP header that can be used to talk
   // to GCD server for authenticated device communication.
@@ -114,6 +120,9 @@
   std::string system_name_ = "coffee_pot";
   std::string display_name_ = "Coffee Pot";
 
+  // HTTP transport used for communications.
+  std::shared_ptr<chromeos::http::Transport> transport_;
+
   DISALLOW_COPY_AND_ASSIGN(DeviceRegistrationInfo);
 };