buffet: Remove 'chromeos' namespace and move everything to buffet NS
As discussed, moved all the classes out of chromeos namespace into
'buffet.
Also fixed a number of cpplint's warnings.
BUG=None
TEST=Everything still compiles and unit tests succeed.
Change-Id: Ide864acb2504627404966727f66d353af60e531d
Reviewed-on: https://chromium-review.googlesource.com/198971
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/buffet/mime_utils.cc b/buffet/mime_utils.cc
index c35d3c0..ca221dc 100644
--- a/buffet/mime_utils.cc
+++ b/buffet/mime_utils.cc
@@ -9,11 +9,11 @@
#include "buffet/string_utils.h"
-using namespace chromeos;
+namespace buffet {
-//***************************************************************************
-//******************************* MIME types ********************************
-//***************************************************************************
+// ***************************************************************************
+// ******************************* MIME types ********************************
+// ***************************************************************************
const char mime::types::kApplication[] = "application";
const char mime::types::kAudio[] = "audio";
const char mime::types::kImage[] = "image";
@@ -39,9 +39,9 @@
const char mime::application::kWwwFormUrlEncoded[] =
"application/x-www-form-urlencoded";
-//***************************************************************************
-//**************************** Utility Functions ****************************
-//***************************************************************************
+// ***************************************************************************
+// **************************** Utility Functions ****************************
+// ***************************************************************************
static std::string EncodeParam(const std::string& param) {
// If the string contains one of "tspecials" characters as
// specified in RFC 1521, enclose it in quotes.
@@ -58,9 +58,9 @@
return param;
}
-//***************************************************************************
-//******************** Main MIME manipulation functions *********************
-//***************************************************************************
+// ***************************************************************************
+// ******************** Main MIME manipulation functions *********************
+// ***************************************************************************
bool mime::Split(const std::string& mime_string,
std::string* type, std::string* subtype,
@@ -72,7 +72,7 @@
if (!mime::Split(parts.front(), type, subtype))
return false;
- if(parameters) {
+ if (parameters) {
parameters->clear();
parameters->reserve(parts.size() - 1);
for (size_t i = 1; i < parts.size(); i++) {
@@ -89,10 +89,10 @@
std::string mime = mime::RemoveParameters(mime_string);
auto types = string_utils::SplitAtFirst(mime, '/');
- if(type)
+ if (type)
*type = types.first;
- if(subtype)
+ if (subtype)
*subtype = types.second;
return !types.first.empty() && !types.second.empty();
@@ -146,9 +146,11 @@
std::string mime::GetParameterValue(const std::string& mime_string,
const std::string& paramName) {
mime::Parameters params = mime::GetParameters(mime_string);
- for(auto&& pair : params) {
+ for (auto&& pair : params) {
if (base::strcasecmp(pair.first.c_str(), paramName.c_str()) == 0)
return pair.second;
}
return std::string();
}
+
+} // namespace buffet
