commit b3aac2520d0ba88ba1aa69c30213bbc21944401e
author Alex Vakulenko <avakulenko@chromium.org> Wed May 07 17:35:24 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Sat May 10 01:32:40 2014 +0000
tree 33cde25604f6ce02fd1ceb1a0b2f08c3c987cf20
parent 48e37283190da8d8f953ef6b199d2782a3a0153b

buffet: Added advanced error reporting

Created chromeos::Error class that encapsulates rich error
information from various system domains.

Swept GCD device registration, HTTP transport and utilities
to always return additional error information when the caller
requests it. This includes internal errors, general HTTP errors
as well as parsing and returning specific GCD and OAuth2 server
error responses.

Also fixed a number of existing linter warnings.

BUG=chromium:366709
TEST=All existing and new unit tests pass.

Change-Id: Ic01622a8efa3dc365ec106e595b09536818b9b23
Reviewed-on: https://chromium-review.googlesource.com/198772
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

buffet/http_connection_fake.cc

diff --git a/buffet/http_connection_fake.cc b/buffet/http_connection_fake.cc
index 6a1c3b9..4372f0d 100644
--- a/buffet/http_connection_fake.cc
+++ b/buffet/http_connection_fake.cc
@@ -10,8 +10,9 @@
 #include "buffet/mime_utils.h"
 #include "buffet/string_utils.h"
 
-using namespace chromeos;
-using namespace chromeos::http::fake;
+namespace chromeos {
+namespace http {
+namespace fake {
 
 Connection::Connection(const std::string& url, const std::string& method,
                        std::shared_ptr<http::Transport> transport) :
@@ -23,20 +24,21 @@
   VLOG(1) << "fake::Connection destroyed";
 }
 
-bool Connection::SendHeaders(const HeaderList& headers) {
+bool Connection::SendHeaders(const HeaderList& headers, ErrorPtr* error) {
   request_.AddHeaders(headers);
   return true;
 }
 
-bool Connection::WriteRequestData(const void* data, size_t size) {
+bool Connection::WriteRequestData(const void* data, size_t size,
+                                  ErrorPtr* error) {
   request_.AddData(data, size);
   return true;
 }
 
-bool Connection::FinishRequest() {
+bool Connection::FinishRequest(ErrorPtr* error) {
   request_.AddHeaders({{request_header::kContentLength,
                       std::to_string(request_.GetData().size())}});
-  fake::Transport* transport = dynamic_cast<fake::Transport*>(transport_.get());
+  fake::Transport* transport = static_cast<fake::Transport*>(transport_.get());
   CHECK(transport) << "Expecting a fake transport";
   auto handler = transport->GetHandler(request_.GetURL(), request_.GetMethod());
   if (handler.is_null()) {
@@ -75,7 +77,7 @@
 }
 
 bool Connection::ReadResponseData(void* data, size_t buffer_size,
-                                  size_t* size_read) {
+                                  size_t* size_read, ErrorPtr* error) {
   size_t size_to_read = GetResponseDataSize() - response_data_ptr_;
   if (size_to_read > buffer_size)
     size_to_read = buffer_size;
@@ -87,6 +89,6 @@
   return true;
 }
 
-std::string Connection::GetErrorMessage() const {
-  return std::string();
-}
+}  // namespace fake
+}  // namespace http
+}  // namespace chromeos