buffet: Added advanced error reporting
Created chromeos::Error class that encapsulates rich error
information from various system domains.
Swept GCD device registration, HTTP transport and utilities
to always return additional error information when the caller
requests it. This includes internal errors, general HTTP errors
as well as parsing and returning specific GCD and OAuth2 server
error responses.
Also fixed a number of existing linter warnings.
BUG=chromium:366709
TEST=All existing and new unit tests pass.
Change-Id: Ic01622a8efa3dc365ec106e595b09536818b9b23
Reviewed-on: https://chromium-review.googlesource.com/198772
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/buffet/http_transport_curl.h b/buffet/http_transport_curl.h
index f63f815..5295794 100644
--- a/buffet/http_transport_curl.h
+++ b/buffet/http_transport_curl.h
@@ -5,12 +5,16 @@
#ifndef BUFFET_HTTP_TRANSPORT_CURL_H_
#define BUFFET_HTTP_TRANSPORT_CURL_H_
+#include <string>
+
#include "buffet/http_transport.h"
namespace chromeos {
namespace http {
namespace curl {
+extern const char kErrorDomain[];
+
///////////////////////////////////////////////////////////////////////////////
// An implementation of http::Transport that uses libcurl for
// HTTP communications. This class (as http::Transport base)
@@ -30,14 +34,14 @@
const HeaderList& headers,
const std::string& user_agent,
const std::string& referer,
- std::string* error_msg) override;
+ ErrorPtr* error) override;
private:
DISALLOW_COPY_AND_ASSIGN(Transport);
};
-} // namespace curl
-} // namespace http
-} // namespace chromeos
+} // namespace curl
+} // namespace http
+} // namespace chromeos
-#endif // BUFFET_HTTP_TRANSPORT_CURL_H_
+#endif // BUFFET_HTTP_TRANSPORT_CURL_H_
