commit b8ba5950da411eb6f9e809bae2835509bcf40119
author Alex Vakulenko <avakulenko@chromium.org> Thu Apr 17 11:35:56 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Apr 18 21:31:57 2014 +0000
tree c2940febedfd59273e6dc974c051e3c919c209db
parent 9001624a6bf48c228a065bd99907816b07705bbd

buffet: fixed the style of using 'const' with pointers and references

Using 'const type*' and 'const type&' instead of 'type const*'...

BUG=None
TEST=Code still compiles.

Change-Id: I3de0e32067563d0e6fd91dcc9a4cd2232bb76b1a
Reviewed-on: https://chromium-review.googlesource.com/195434
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

buffet/mime_utils.cc

diff --git a/buffet/mime_utils.cc b/buffet/mime_utils.cc
index a4f29ca..c35d3c0 100644
--- a/buffet/mime_utils.cc
+++ b/buffet/mime_utils.cc
@@ -42,7 +42,7 @@
 //***************************************************************************
 //**************************** Utility Functions ****************************
 //***************************************************************************
-static std::string EncodeParam(std::string const& param) {
+static std::string EncodeParam(const std::string& param) {
   // If the string contains one of "tspecials" characters as
   // specified in RFC 1521, enclose it in quotes.
   if (param.find_first_of("()<>@,;:\\\"/[]?=") != std::string::npos) {
@@ -51,7 +51,7 @@
   return param;
 }
 
-static std::string DecodeParam(std::string const& param) {
+static std::string DecodeParam(const std::string& param) {
   if (param.size() > 1 && param.front() == '"' && param.back() == '"') {
     return param.substr(1, param.size() - 2);
   }
@@ -62,7 +62,7 @@
 //******************** Main MIME manipulation functions *********************
 //***************************************************************************
 
-bool mime::Split(std::string const& mime_string,
+bool mime::Split(const std::string& mime_string,
                  std::string* type, std::string* subtype,
                  mime::Parameters* parameters) {
   std::vector<std::string> parts = string_utils::Split(mime_string, ';');
@@ -84,7 +84,7 @@
   return true;
 }
 
-bool mime::Split(std::string const& mime_string,
+bool mime::Split(const std::string& mime_string,
                  std::string* type, std::string* subtype) {
   std::string mime = mime::RemoveParameters(mime_string);
   auto types = string_utils::SplitAtFirst(mime, '/');
@@ -98,28 +98,28 @@
   return !types.first.empty() && !types.second.empty();
 }
 
-std::string mime::Combine(std::string const& type, std::string const& subtype,
-                          mime::Parameters const& parameters) {
+std::string mime::Combine(const std::string& type, const std::string& subtype,
+                          const mime::Parameters& parameters) {
   std::vector<std::string> parts;
   parts.push_back(string_utils::Join('/', type, subtype));
-  for (std::pair<std::string, std::string> const& pair : parameters) {
+  for (auto&& pair : parameters) {
     parts.push_back(string_utils::Join('=', pair.first,
                                        EncodeParam(pair.second)));
   }
   return string_utils::Join("; ", parts);
 }
 
-std::string mime::GetType(std::string const& mime_string) {
+std::string mime::GetType(const std::string& mime_string) {
   std::string mime = mime::RemoveParameters(mime_string);
   return string_utils::SplitAtFirst(mime, '/').first;
 }
 
-std::string mime::GetSubtype(std::string const& mime_string) {
+std::string mime::GetSubtype(const std::string& mime_string) {
   std::string mime = mime::RemoveParameters(mime_string);
   return string_utils::SplitAtFirst(mime, '/').second;
 }
 
-mime::Parameters mime::GetParameters(std::string const& mime_string) {
+mime::Parameters mime::GetParameters(const std::string& mime_string) {
   std::string type;
   std::string subtype;
   mime::Parameters parameters;
@@ -130,23 +130,23 @@
   return mime::Parameters();
 }
 
-std::string mime::RemoveParameters(std::string const& mime_string) {
+std::string mime::RemoveParameters(const std::string& mime_string) {
   return string_utils::SplitAtFirst(mime_string, ';').first;
 }
 
-std::string mime::AppendParameter(std::string const& mime_string,
-                                  std::string const& paramName,
-                                  std::string const& paramValue) {
+std::string mime::AppendParameter(const std::string& mime_string,
+                                  const std::string& paramName,
+                                  const std::string& paramValue) {
   std::string mime(mime_string);
   mime += "; ";
   mime += string_utils::Join('=', paramName, EncodeParam(paramValue));
   return mime;
 }
 
-std::string mime::GetParameterValue(std::string const& mime_string,
-                                    std::string const& paramName) {
+std::string mime::GetParameterValue(const std::string& mime_string,
+                                    const std::string& paramName) {
   mime::Parameters params = mime::GetParameters(mime_string);
-  for(auto const& pair : params) {
+  for(auto&& pair : params) {
     if (base::strcasecmp(pair.first.c_str(), paramName.c_str()) == 0)
       return pair.second;
   }