commit db770e704369c5b70f63ec28fdd51329ae2f3ef9
author Vitaly Buka <vitalybuka@chromium.org> Tue Mar 10 19:33:33 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Fri Mar 13 11:31:13 2015 +0000
tree 43900dce96d2bf7dc4bb7cbc74d96334503ab0c5
parent 6ca3ad6ccfa620ba8c76a42e1a25bd47cef54f1e

libchromeos: Replace char with std::string in string_utils API

std::string version of functions is enough to cover char use cases.
C library was replaced with STL in Split and SplitAtFirst implementations.
Added support of splitting by empty string. Uses but reasonable implementation
is simple.

BUG=none
TEST=unittests

Change-Id: I0778722d31a7b06eea2227b4d94991ab194195cb
Reviewed-on: https://chromium-review.googlesource.com/258640
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Tested-by: Vitaly Buka <vitalybuka@chromium.org>

buffet/states/state_manager.cc

diff --git a/buffet/states/state_manager.cc b/buffet/states/state_manager.cc
index d98015d..827cd7f 100644
--- a/buffet/states/state_manager.cc
+++ b/buffet/states/state_manager.cc
@@ -111,7 +111,7 @@
   std::string package_name;
   std::string property_name;
   bool split = chromeos::string_utils::SplitAtFirst(
-      full_property_name, '.', &package_name, &property_name);
+      full_property_name, ".", &package_name, &property_name);
   if (full_property_name.empty() || (split && property_name.empty())) {
     chromeos::Error::AddTo(error, FROM_HERE, errors::state::kDomain,
                            errors::state::kPropertyNameMissing,