)]}'
{
  "commit": "e63dde6a5f745c5c8202c3650c7b1b0c5365cd78",
  "tree": "45563723b3da877bbea4080c12c908b7131ab990",
  "parents": [
    "7e8df46a6608bd9b398f160caf4b626d8717e437"
  ],
  "author": {
    "name": "Alex Vakulenko",
    "email": "avakulenko@chromium.org",
    "time": "Wed Jul 08 10:58:01 2015 -0700"
  },
  "committer": {
    "name": "ChromeOS Commit Bot",
    "email": "chromeos-commit-bot@chromium.org",
    "time": "Wed Jul 08 21:10:13 2015 +0000"
  },
  "message": "libweave: Crash in XMPP ping when there is no XMPP connection\n\nWhen there is no active XMPP connection to the server and ping timer\nfires, we try to send a ping request to the server, but there is no\nsocket stream (nullptr) and buffet crashes in XmppChannel::SendMessage().\n\nWhen XmppChannel::PingServer() is called with the XMPP channel in\n\"not connected\" state, it means only that a network connectivity change\nnotification has arrived (because the regular ping will be disabled\nuntil we re-establish XMPP connection). In case PingServer is called\nwith no XMPP connection established, restart XMPP channel and try to\nconnect to the server.\n\nBUG\u003dbrillo:1237\nTEST\u003d`FEATURES\u003dtest emerge-link buffet`\n     Deployed on the device and observed buffet while fiddling with network with\n     `while true; do echo up; ifconfig eth0 up; sleep 90; echo down;ifconfig eth0 down; sleep 90; done`\n\nChange-Id: I26e799cdde078e20a28ed92ba654073131c1daa8\nReviewed-on: https://chromium-review.googlesource.com/284002\nTrybot-Ready: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nTested-by: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\nReviewed-by: Vitaly Buka \u003cvitalybuka@chromium.org\u003e\nCommit-Queue: Alex Vakulenko \u003cavakulenko@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "542ad610fd2122766fb6025e3c0e6408cfaec417",
      "old_mode": 33188,
      "old_path": "libweave/src/notification/xmpp_channel.cc",
      "new_id": "c7bc35b3ace22bd7fb9c8cb4dc5096d1777f8221",
      "new_mode": 33188,
      "new_path": "libweave/src/notification/xmpp_channel.cc"
    }
  ]
}