tree 45563723b3da877bbea4080c12c908b7131ab990
parent 7e8df46a6608bd9b398f160caf4b626d8717e437
author Alex Vakulenko <avakulenko@chromium.org> 1436378281 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> 1436389813 +0000

libweave: Crash in XMPP ping when there is no XMPP connection

When there is no active XMPP connection to the server and ping timer
fires, we try to send a ping request to the server, but there is no
socket stream (nullptr) and buffet crashes in XmppChannel::SendMessage().

When XmppChannel::PingServer() is called with the XMPP channel in
"not connected" state, it means only that a network connectivity change
notification has arrived (because the regular ping will be disabled
until we re-establish XMPP connection). In case PingServer is called
with no XMPP connection established, restart XMPP channel and try to
connect to the server.

BUG=brillo:1237
TEST=`FEATURES=test emerge-link buffet`
     Deployed on the device and observed buffet while fiddling with network with
     `while true; do echo up; ifconfig eth0 up; sleep 90; echo down;ifconfig eth0 down; sleep 90; done`

Change-Id: I26e799cdde078e20a28ed92ba654073131c1daa8
Reviewed-on: https://chromium-review.googlesource.com/284002
Trybot-Ready: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>