commit 0de42f5abc87364a681a0d8f40c06f2ec1516059
author Vitaly Buka <vitalybuka@google.com> Sun Dec 13 18:47:13 2015 -0800
committer Vitaly Buka <vitalybuka@google.com> Mon Dec 14 22:16:26 2015 +0000
tree 0eb209fe02aac20b2e1b35cf582542877f742789
parent 76e924f2ebbb23d1589c7bdc8241c9987175ea91

Add test to verify that token from different secret is not accepted

Token is generated by one AuthManager and passed into another for
parsing. As AuthManager have different secrets, parsing should fail.

Change-Id: I5d83cf579690eeafc6745f516c3ccb2702423039
Reviewed-on: https://weave-review.googlesource.com/1945
Reviewed-by: Alex Vakulenko <avakulenko@google.com>

src/privet/auth_manager.cc

diff --git a/src/privet/auth_manager.cc b/src/privet/auth_manager.cc
index 6a79b93..8e2bfce 100644
--- a/src/privet/auth_manager.cc
+++ b/src/privet/auth_manager.cc
@@ -51,7 +51,8 @@
   int64_t timestamp{0};
   if (!base::StringToInt64(parts[2], &timestamp))
     return kNone;
-  *time = base::Time::FromTimeT(timestamp);
+  if (time)
+    *time = base::Time::FromTimeT(timestamp);
   return UserInfo{static_cast<AuthScope>(scope), id};
 }
 

src/privet/auth_manager_unittest.cc

diff --git a/src/privet/auth_manager_unittest.cc b/src/privet/auth_manager_unittest.cc
index a7aa621..6a48f11 100644
--- a/src/privet/auth_manager_unittest.cc
+++ b/src/privet/auth_manager_unittest.cc
@@ -108,6 +108,7 @@
 
     auto token = auth.CreateAccessToken(UserInfo{AuthScope::kUser, 5});
     base::Time time2;
+    EXPECT_EQ(AuthScope::kNone, auth_.ParseAccessToken(token, nullptr).scope());
     EXPECT_EQ(AuthScope::kUser, auth.ParseAccessToken(token, &time2).scope());
     EXPECT_EQ(5u, auth.ParseAccessToken(token, &time2).user_id());
     // Token timestamp resolution is one second.