Mark request as failed even if server replied with error Existing behavior was able to spam server with badly formated requests. Change-Id: I10595bae8693a8ca6bb694a6e495da89ae394de9 Reviewed-on: https://weave-review.googlesource.com/1992 Reviewed-by: Alex Vakulenko <avakulenko@google.com>
diff --git a/src/device_registration_info.cc b/src/device_registration_info.cc index 4e5b345..445c138 100644 --- a/src/device_registration_info.cc +++ b/src/device_registration_info.cc
@@ -721,7 +721,7 @@ auto json_resp = ParseJsonResponse(*response, &error); if (!json_resp) { - cloud_backoff_entry_->InformOfRequest(true); + cloud_backoff_entry_->InformOfRequest(false); return data->callback.Run({}, std::move(error)); } @@ -732,7 +732,8 @@ // If we exceeded server quota, retry the request later. return RetryCloudRequest(data); } - cloud_backoff_entry_->InformOfRequest(true); + + cloud_backoff_entry_->InformOfRequest(false); return data->callback.Run({}, std::move(error)); }