commit 5fddf87b36b0528e8251b25ae2eba3336fd028dd
author Vitaly Buka <vitalybuka@google.com> Tue Dec 15 22:08:36 2015 -0800
committer Vitaly Buka <vitalybuka@google.com> Wed Dec 16 18:06:27 2015 +0000
tree e1c001618a4f630b1eefaf3e5a5f4eca7d0cd697
parent 9921b87a837f324951eb0eba4d971cfe854edf27

Mark request as failed even if server replied with error

Existing behavior was able to spam server with badly formated requests.

Change-Id: I10595bae8693a8ca6bb694a6e495da89ae394de9
Reviewed-on: https://weave-review.googlesource.com/1992
Reviewed-by: Alex Vakulenko <avakulenko@google.com>

src/device_registration_info.cc

diff --git a/src/device_registration_info.cc b/src/device_registration_info.cc
index 4e5b345..445c138 100644
--- a/src/device_registration_info.cc
+++ b/src/device_registration_info.cc
@@ -721,7 +721,7 @@
 
   auto json_resp = ParseJsonResponse(*response, &error);
   if (!json_resp) {
-    cloud_backoff_entry_->InformOfRequest(true);
+    cloud_backoff_entry_->InformOfRequest(false);
     return data->callback.Run({}, std::move(error));
   }
 
@@ -732,7 +732,8 @@
       // If we exceeded server quota, retry the request later.
       return RetryCloudRequest(data);
     }
-    cloud_backoff_entry_->InformOfRequest(true);
+
+    cloud_backoff_entry_->InformOfRequest(false);
     return data->callback.Run({}, std::move(error));
   }