libweave: Always fetch commands from server, even if XMPP delivers JSON
XMPP notification may include the command payload in its message. If it
it does, we normally don't go to the cloud server and fetch the current
command queue. However if XMPP notification is missed, there is no easy
way of obtaining the missed command.
If we use the notification as a cue to pull the current command queue
from the server, we would also pull any missed commands from earlier
missed notifications.
BUG: None
Change-Id: I85f0c2e58df7c2e6d2ce1be034d3c367870f7f7a
Reviewed-on: https://weave-review.googlesource.com/3170
Reviewed-by: Robert Ginda <rginda@google.com>
diff --git a/src/device_registration_info.cc b/src/device_registration_info.cc
index 31a3965..195895f 100644
--- a/src/device_registration_info.cc
+++ b/src/device_registration_info.cc
@@ -1331,13 +1331,6 @@
VLOG(1) << "Command notification received: " << command;
- if (!command.empty()) {
- // GCD spec indicates that the command parameter in notification object
- // "may be empty if command size is too big".
- PublishCommand(command);
- return;
- }
-
// If the command was too big to be delivered over a notification channel,
// or OnCommandCreated() was initiated from the Pull notification,
// perform a manual command fetch from the server here.
