commit d07e206c4d71c118516054752a69911d04c98fba
author Anton Muhin <antonm@google.com> Mon Oct 27 10:53:29 2014 +0400
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Oct 29 18:37:40 2014 +0000
tree 9a1f3b10eca1bc33790d42b353e1bf046bdd079f
parent c635c59187409cd66c3dc3d1fc749106b2d92522

buffet: Implement command polling.

Now we periodically fetch the queue of commands to run
and publish them via CommandManager.

BUG=chromium:420604
TEST=cros_workon_make buffet --test&&manual

Change-Id: Idfa22145fcfa8d38ab44c1a65cfc5a4469d7c4e1
Reviewed-on: https://chromium-review.googlesource.com/225910
Commit-Queue: Anton Muhin <antonm@chromium.org>
Tested-by: Anton Muhin <antonm@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>

buffet/device_registration_info.cc

diff --git a/buffet/device_registration_info.cc b/buffet/device_registration_info.cc
index 330b515..d4cee76 100644
--- a/buffet/device_registration_info.cc
+++ b/buffet/device_registration_info.cc
@@ -711,11 +711,40 @@
 }
 
 void DeviceRegistrationInfo::PeriodicallyPollCommands() {
-  auto delay = base::TimeDelta::FromSeconds(7);
-  PostRepeatingTask(FROM_HERE, base::Bind([]{
-    VLOG(1) << "Poll commands";
-    // TODO(antonm): Implement real polling of commands.
-  }), delay);
+  VLOG(1) << "Poll commands";
+  PostRepeatingTask(
+      FROM_HERE,
+      base::Bind(
+          &DeviceRegistrationInfo::FetchCommands,
+          base::Unretained(this),
+          base::Bind(&DeviceRegistrationInfo::PublishCommands,
+                     base::Unretained(this))),
+      base::TimeDelta::FromSeconds(7));
+}
+
+void DeviceRegistrationInfo::PublishCommands(const base::ListValue& commands) {
+  const CommandDictionary& command_dictionary =
+      command_manager_->GetCommandDictionary();
+
+  const size_t size{commands.GetSize()};
+  for (size_t i = 0; i < size; ++i) {
+    const base::DictionaryValue* command{nullptr};
+    if (!commands.GetDictionary(i, &command)) {
+      LOG(WARNING) << "No command resource at " << i;
+      continue;
+    }
+
+    std::unique_ptr<CommandInstance> command_instance =
+        CommandInstance::FromJson(command, command_dictionary, nullptr);
+    if (!command_instance) {
+      LOG(WARNING) << "Failed to parse a command";
+      continue;
+    }
+
+    // TODO(antonm): Double check if there is a chance to publish
+    // the same command twice if it doesn't change its status.
+    command_manager_->AddCommand(std::move(command_instance));
+  }
 }
 
 }  // namespace buffet

buffet/device_registration_info.h

diff --git a/buffet/device_registration_info.h b/buffet/device_registration_info.h
index c683e37..c9b6335 100644
--- a/buffet/device_registration_info.h
+++ b/buffet/device_registration_info.h
@@ -145,6 +145,8 @@
 
   void PeriodicallyPollCommands();
 
+  void PublishCommands(const base::ListValue& commands);
+
   // Builds Cloud API devices collection REST resouce which matches
   // current state of the device including command definitions
   // for all supported commands and current device state.