blob: a5f2530bc1c02e4500a7c391c85b7fa055f2d000 [file] [log] [blame]
Vitaly Bukacbed2062015-08-17 12:54:05 -07001// Copyright (c) 2012 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
5#include "base/json/json_reader.h"
6
Vitaly Buka8750b272015-08-18 18:39:08 -07007#include <gtest/gtest.h>
8
9#include "base/build/build_config.h"
Vitaly Bukacbed2062015-08-17 12:54:05 -070010#include "base/logging.h"
11#include "base/memory/scoped_ptr.h"
Vitaly Bukacbed2062015-08-17 12:54:05 -070012#include "base/strings/string_piece.h"
Vitaly Buka8750b272015-08-18 18:39:08 -070013#include "base/strings/utf_string_conversion_utils.h"
Vitaly Bukacbed2062015-08-17 12:54:05 -070014#include "base/values.h"
Vitaly Bukacbed2062015-08-17 12:54:05 -070015
16namespace base {
17
18TEST(JSONReaderTest, Reading) {
19 // some whitespace checking
20 scoped_ptr<Value> root;
21 root = JSONReader().ReadToValue(" null ");
22 ASSERT_TRUE(root.get());
23 EXPECT_TRUE(root->IsType(Value::TYPE_NULL));
24
25 // Invalid JSON string
26 root = JSONReader().ReadToValue("nu");
27 EXPECT_FALSE(root.get());
28
29 // Simple bool
30 root = JSONReader().ReadToValue("true ");
31 ASSERT_TRUE(root.get());
32 EXPECT_TRUE(root->IsType(Value::TYPE_BOOLEAN));
33
34 // Embedded comment
35 root = JSONReader().ReadToValue("/* comment */null");
36 ASSERT_TRUE(root.get());
37 EXPECT_TRUE(root->IsType(Value::TYPE_NULL));
38 root = JSONReader().ReadToValue("40 /* comment */");
39 ASSERT_TRUE(root.get());
40 EXPECT_TRUE(root->IsType(Value::TYPE_INTEGER));
41 root = JSONReader().ReadToValue("true // comment");
42 ASSERT_TRUE(root.get());
43 EXPECT_TRUE(root->IsType(Value::TYPE_BOOLEAN));
44 root = JSONReader().ReadToValue("/* comment */\"sample string\"");
45 ASSERT_TRUE(root.get());
46 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
47 std::string value;
48 EXPECT_TRUE(root->GetAsString(&value));
49 EXPECT_EQ("sample string", value);
50 root = JSONReader().ReadToValue("[1, /* comment, 2 ] */ \n 3]");
51 ASSERT_TRUE(root.get());
52 ListValue* list = static_cast<ListValue*>(root.get());
53 EXPECT_EQ(2u, list->GetSize());
54 int int_val = 0;
55 EXPECT_TRUE(list->GetInteger(0, &int_val));
56 EXPECT_EQ(1, int_val);
57 EXPECT_TRUE(list->GetInteger(1, &int_val));
58 EXPECT_EQ(3, int_val);
59 root = JSONReader().ReadToValue("[1, /*a*/2, 3]");
60 ASSERT_TRUE(root.get());
61 list = static_cast<ListValue*>(root.get());
62 EXPECT_EQ(3u, list->GetSize());
63 root = JSONReader().ReadToValue("/* comment **/42");
64 ASSERT_TRUE(root.get());
65 EXPECT_TRUE(root->IsType(Value::TYPE_INTEGER));
66 EXPECT_TRUE(root->GetAsInteger(&int_val));
67 EXPECT_EQ(42, int_val);
68 root = JSONReader().ReadToValue(
69 "/* comment **/\n"
70 "// */ 43\n"
71 "44");
72 ASSERT_TRUE(root.get());
73 EXPECT_TRUE(root->IsType(Value::TYPE_INTEGER));
74 EXPECT_TRUE(root->GetAsInteger(&int_val));
75 EXPECT_EQ(44, int_val);
76
77 // Test number formats
78 root = JSONReader().ReadToValue("43");
79 ASSERT_TRUE(root.get());
80 EXPECT_TRUE(root->IsType(Value::TYPE_INTEGER));
81 EXPECT_TRUE(root->GetAsInteger(&int_val));
82 EXPECT_EQ(43, int_val);
83
84 // According to RFC4627, oct, hex, and leading zeros are invalid JSON.
85 root = JSONReader().ReadToValue("043");
86 EXPECT_FALSE(root.get());
87 root = JSONReader().ReadToValue("0x43");
88 EXPECT_FALSE(root.get());
89 root = JSONReader().ReadToValue("00");
90 EXPECT_FALSE(root.get());
91
92 // Test 0 (which needs to be special cased because of the leading zero
93 // clause).
94 root = JSONReader().ReadToValue("0");
95 ASSERT_TRUE(root.get());
96 EXPECT_TRUE(root->IsType(Value::TYPE_INTEGER));
97 int_val = 1;
98 EXPECT_TRUE(root->GetAsInteger(&int_val));
99 EXPECT_EQ(0, int_val);
100
101 // Numbers that overflow ints should succeed, being internally promoted to
102 // storage as doubles
103 root = JSONReader().ReadToValue("2147483648");
104 ASSERT_TRUE(root.get());
105 double double_val;
106 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
107 double_val = 0.0;
108 EXPECT_TRUE(root->GetAsDouble(&double_val));
109 EXPECT_DOUBLE_EQ(2147483648.0, double_val);
110 root = JSONReader().ReadToValue("-2147483649");
111 ASSERT_TRUE(root.get());
112 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
113 double_val = 0.0;
114 EXPECT_TRUE(root->GetAsDouble(&double_val));
115 EXPECT_DOUBLE_EQ(-2147483649.0, double_val);
116
117 // Parse a double
118 root = JSONReader().ReadToValue("43.1");
119 ASSERT_TRUE(root.get());
120 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
121 double_val = 0.0;
122 EXPECT_TRUE(root->GetAsDouble(&double_val));
123 EXPECT_DOUBLE_EQ(43.1, double_val);
124
125 root = JSONReader().ReadToValue("4.3e-1");
126 ASSERT_TRUE(root.get());
127 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
128 double_val = 0.0;
129 EXPECT_TRUE(root->GetAsDouble(&double_val));
130 EXPECT_DOUBLE_EQ(.43, double_val);
131
132 root = JSONReader().ReadToValue("2.1e0");
133 ASSERT_TRUE(root.get());
134 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
135 double_val = 0.0;
136 EXPECT_TRUE(root->GetAsDouble(&double_val));
137 EXPECT_DOUBLE_EQ(2.1, double_val);
138
139 root = JSONReader().ReadToValue("2.1e+0001");
140 ASSERT_TRUE(root.get());
141 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
142 double_val = 0.0;
143 EXPECT_TRUE(root->GetAsDouble(&double_val));
144 EXPECT_DOUBLE_EQ(21.0, double_val);
145
146 root = JSONReader().ReadToValue("0.01");
147 ASSERT_TRUE(root.get());
148 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
149 double_val = 0.0;
150 EXPECT_TRUE(root->GetAsDouble(&double_val));
151 EXPECT_DOUBLE_EQ(0.01, double_val);
152
153 root = JSONReader().ReadToValue("1.00");
154 ASSERT_TRUE(root.get());
155 EXPECT_TRUE(root->IsType(Value::TYPE_DOUBLE));
156 double_val = 0.0;
157 EXPECT_TRUE(root->GetAsDouble(&double_val));
158 EXPECT_DOUBLE_EQ(1.0, double_val);
159
160 // Fractional parts must have a digit before and after the decimal point.
161 root = JSONReader().ReadToValue("1.");
162 EXPECT_FALSE(root.get());
163 root = JSONReader().ReadToValue(".1");
164 EXPECT_FALSE(root.get());
165 root = JSONReader().ReadToValue("1.e10");
166 EXPECT_FALSE(root.get());
167
168 // Exponent must have a digit following the 'e'.
169 root = JSONReader().ReadToValue("1e");
170 EXPECT_FALSE(root.get());
171 root = JSONReader().ReadToValue("1E");
172 EXPECT_FALSE(root.get());
173 root = JSONReader().ReadToValue("1e1.");
174 EXPECT_FALSE(root.get());
175 root = JSONReader().ReadToValue("1e1.0");
176 EXPECT_FALSE(root.get());
177
178 // INF/-INF/NaN are not valid
179 root = JSONReader().ReadToValue("1e1000");
180 EXPECT_FALSE(root.get());
181 root = JSONReader().ReadToValue("-1e1000");
182 EXPECT_FALSE(root.get());
183 root = JSONReader().ReadToValue("NaN");
184 EXPECT_FALSE(root.get());
185 root = JSONReader().ReadToValue("nan");
186 EXPECT_FALSE(root.get());
187 root = JSONReader().ReadToValue("inf");
188 EXPECT_FALSE(root.get());
189
190 // Invalid number formats
191 root = JSONReader().ReadToValue("4.3.1");
192 EXPECT_FALSE(root.get());
193 root = JSONReader().ReadToValue("4e3.1");
194 EXPECT_FALSE(root.get());
195
196 // Test string parser
197 root = JSONReader().ReadToValue("\"hello world\"");
198 ASSERT_TRUE(root.get());
199 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
200 std::string str_val;
201 EXPECT_TRUE(root->GetAsString(&str_val));
202 EXPECT_EQ("hello world", str_val);
203
204 // Empty string
205 root = JSONReader().ReadToValue("\"\"");
206 ASSERT_TRUE(root.get());
207 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
208 str_val.clear();
209 EXPECT_TRUE(root->GetAsString(&str_val));
210 EXPECT_EQ("", str_val);
211
212 // Test basic string escapes
213 root = JSONReader().ReadToValue("\" \\\"\\\\\\/\\b\\f\\n\\r\\t\\v\"");
214 ASSERT_TRUE(root.get());
215 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
216 str_val.clear();
217 EXPECT_TRUE(root->GetAsString(&str_val));
218 EXPECT_EQ(" \"\\/\b\f\n\r\t\v", str_val);
219
220 // Test hex and unicode escapes including the null character.
221 root = JSONReader().ReadToValue("\"\\x41\\x00\\u1234\"");
222 ASSERT_TRUE(root.get());
223 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
224 str_val.clear();
225 EXPECT_TRUE(root->GetAsString(&str_val));
Vitaly Buka8750b272015-08-18 18:39:08 -0700226 EXPECT_EQ((std::string{'A', '\0', '\xE1', '\x88', '\xB4'}), str_val);
Vitaly Bukacbed2062015-08-17 12:54:05 -0700227
228 // Test invalid strings
229 root = JSONReader().ReadToValue("\"no closing quote");
230 EXPECT_FALSE(root.get());
231 root = JSONReader().ReadToValue("\"\\z invalid escape char\"");
232 EXPECT_FALSE(root.get());
233 root = JSONReader().ReadToValue("\"\\xAQ invalid hex code\"");
234 EXPECT_FALSE(root.get());
235 root = JSONReader().ReadToValue("not enough hex chars\\x1\"");
236 EXPECT_FALSE(root.get());
237 root = JSONReader().ReadToValue("\"not enough escape chars\\u123\"");
238 EXPECT_FALSE(root.get());
239 root = JSONReader().ReadToValue("\"extra backslash at end of input\\\"");
240 EXPECT_FALSE(root.get());
241
242 // Basic array
243 root.reset(JSONReader::DeprecatedRead("[true, false, null]"));
244 ASSERT_TRUE(root.get());
245 EXPECT_TRUE(root->IsType(Value::TYPE_LIST));
246 list = static_cast<ListValue*>(root.get());
247 EXPECT_EQ(3U, list->GetSize());
248
249 // Test with trailing comma. Should be parsed the same as above.
250 scoped_ptr<Value> root2;
251 root2.reset(JSONReader::DeprecatedRead("[true, false, null, ]",
252 JSON_ALLOW_TRAILING_COMMAS));
253 EXPECT_TRUE(root->Equals(root2.get()));
254
255 // Empty array
256 root.reset(JSONReader::DeprecatedRead("[]"));
257 ASSERT_TRUE(root.get());
258 EXPECT_TRUE(root->IsType(Value::TYPE_LIST));
259 list = static_cast<ListValue*>(root.get());
260 EXPECT_EQ(0U, list->GetSize());
261
262 // Nested arrays
263 root.reset(
264 JSONReader::DeprecatedRead("[[true], [], [false, [], [null]], null]"));
265 ASSERT_TRUE(root.get());
266 EXPECT_TRUE(root->IsType(Value::TYPE_LIST));
267 list = static_cast<ListValue*>(root.get());
268 EXPECT_EQ(4U, list->GetSize());
269
270 // Lots of trailing commas.
271 root2.reset(JSONReader::DeprecatedRead(
272 "[[true], [], [false, [], [null, ] , ], null,]",
273 JSON_ALLOW_TRAILING_COMMAS));
274 EXPECT_TRUE(root->Equals(root2.get()));
275
276 // Invalid, missing close brace.
277 root.reset(
278 JSONReader::DeprecatedRead("[[true], [], [false, [], [null]], null"));
279 EXPECT_FALSE(root.get());
280
281 // Invalid, too many commas
282 root.reset(JSONReader::DeprecatedRead("[true,, null]"));
283 EXPECT_FALSE(root.get());
284 root.reset(
285 JSONReader::DeprecatedRead("[true,, null]", JSON_ALLOW_TRAILING_COMMAS));
286 EXPECT_FALSE(root.get());
287
288 // Invalid, no commas
289 root.reset(JSONReader::DeprecatedRead("[true null]"));
290 EXPECT_FALSE(root.get());
291
292 // Invalid, trailing comma
293 root.reset(JSONReader::DeprecatedRead("[true,]"));
294 EXPECT_FALSE(root.get());
295
296 // Valid if we set |allow_trailing_comma| to true.
297 root.reset(JSONReader::DeprecatedRead("[true,]", JSON_ALLOW_TRAILING_COMMAS));
298 ASSERT_TRUE(root.get());
299 EXPECT_TRUE(root->IsType(Value::TYPE_LIST));
300 list = static_cast<ListValue*>(root.get());
301 EXPECT_EQ(1U, list->GetSize());
302 Value* tmp_value = NULL;
303 ASSERT_TRUE(list->Get(0, &tmp_value));
304 EXPECT_TRUE(tmp_value->IsType(Value::TYPE_BOOLEAN));
305 bool bool_value = false;
306 EXPECT_TRUE(tmp_value->GetAsBoolean(&bool_value));
307 EXPECT_TRUE(bool_value);
308
309 // Don't allow empty elements, even if |allow_trailing_comma| is
310 // true.
311 root.reset(JSONReader::DeprecatedRead("[,]", JSON_ALLOW_TRAILING_COMMAS));
312 EXPECT_FALSE(root.get());
313 root.reset(
314 JSONReader::DeprecatedRead("[true,,]", JSON_ALLOW_TRAILING_COMMAS));
315 EXPECT_FALSE(root.get());
316 root.reset(
317 JSONReader::DeprecatedRead("[,true,]", JSON_ALLOW_TRAILING_COMMAS));
318 EXPECT_FALSE(root.get());
319 root.reset(
320 JSONReader::DeprecatedRead("[true,,false]", JSON_ALLOW_TRAILING_COMMAS));
321 EXPECT_FALSE(root.get());
322
323 // Test objects
324 root.reset(JSONReader::DeprecatedRead("{}"));
325 ASSERT_TRUE(root.get());
326 EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
327
328 root.reset(JSONReader::DeprecatedRead(
329 "{\"number\":9.87654321, \"null\":null , \"\\x53\" : \"str\" }"));
330 ASSERT_TRUE(root.get());
331 EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
332 DictionaryValue* dict_val = static_cast<DictionaryValue*>(root.get());
333 double_val = 0.0;
334 EXPECT_TRUE(dict_val->GetDouble("number", &double_val));
335 EXPECT_DOUBLE_EQ(9.87654321, double_val);
336 Value* null_val = NULL;
337 ASSERT_TRUE(dict_val->Get("null", &null_val));
338 EXPECT_TRUE(null_val->IsType(Value::TYPE_NULL));
339 str_val.clear();
340 EXPECT_TRUE(dict_val->GetString("S", &str_val));
341 EXPECT_EQ("str", str_val);
342
343 root2.reset(JSONReader::DeprecatedRead(
344 "{\"number\":9.87654321, \"null\":null , \"\\x53\" : \"str\", }",
345 JSON_ALLOW_TRAILING_COMMAS));
346 ASSERT_TRUE(root2.get());
347 EXPECT_TRUE(root->Equals(root2.get()));
348
349 // Test newline equivalence.
350 root2.reset(JSONReader::DeprecatedRead(
351 "{\n"
352 " \"number\":9.87654321,\n"
353 " \"null\":null,\n"
354 " \"\\x53\":\"str\",\n"
355 "}\n",
356 JSON_ALLOW_TRAILING_COMMAS));
357 ASSERT_TRUE(root2.get());
358 EXPECT_TRUE(root->Equals(root2.get()));
359
360 root2.reset(JSONReader::DeprecatedRead(
361 "{\r\n"
362 " \"number\":9.87654321,\r\n"
363 " \"null\":null,\r\n"
364 " \"\\x53\":\"str\",\r\n"
365 "}\r\n",
366 JSON_ALLOW_TRAILING_COMMAS));
367 ASSERT_TRUE(root2.get());
368 EXPECT_TRUE(root->Equals(root2.get()));
369
370 // Test nesting
371 root.reset(JSONReader::DeprecatedRead(
372 "{\"inner\":{\"array\":[true]},\"false\":false,\"d\":{}}"));
373 ASSERT_TRUE(root.get());
374 EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
375 dict_val = static_cast<DictionaryValue*>(root.get());
376 DictionaryValue* inner_dict = NULL;
377 ASSERT_TRUE(dict_val->GetDictionary("inner", &inner_dict));
378 ListValue* inner_array = NULL;
379 ASSERT_TRUE(inner_dict->GetList("array", &inner_array));
380 EXPECT_EQ(1U, inner_array->GetSize());
381 bool_value = true;
382 EXPECT_TRUE(dict_val->GetBoolean("false", &bool_value));
383 EXPECT_FALSE(bool_value);
384 inner_dict = NULL;
385 EXPECT_TRUE(dict_val->GetDictionary("d", &inner_dict));
386
387 root2.reset(JSONReader::DeprecatedRead(
388 "{\"inner\": {\"array\":[true] , },\"false\":false,\"d\":{},}",
389 JSON_ALLOW_TRAILING_COMMAS));
390 EXPECT_TRUE(root->Equals(root2.get()));
391
392 // Test keys with periods
393 root.reset(JSONReader::DeprecatedRead(
394 "{\"a.b\":3,\"c\":2,\"d.e.f\":{\"g.h.i.j\":1}}"));
395 ASSERT_TRUE(root.get());
396 EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
397 dict_val = static_cast<DictionaryValue*>(root.get());
398 int integer_value = 0;
399 EXPECT_TRUE(dict_val->GetIntegerWithoutPathExpansion("a.b", &integer_value));
400 EXPECT_EQ(3, integer_value);
401 EXPECT_TRUE(dict_val->GetIntegerWithoutPathExpansion("c", &integer_value));
402 EXPECT_EQ(2, integer_value);
403 inner_dict = NULL;
404 ASSERT_TRUE(dict_val->GetDictionaryWithoutPathExpansion("d.e.f",
405 &inner_dict));
406 EXPECT_EQ(1U, inner_dict->size());
407 EXPECT_TRUE(inner_dict->GetIntegerWithoutPathExpansion("g.h.i.j",
408 &integer_value));
409 EXPECT_EQ(1, integer_value);
410
411 root.reset(JSONReader::DeprecatedRead("{\"a\":{\"b\":2},\"a.b\":1}"));
412 ASSERT_TRUE(root.get());
413 EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
414 dict_val = static_cast<DictionaryValue*>(root.get());
415 EXPECT_TRUE(dict_val->GetInteger("a.b", &integer_value));
416 EXPECT_EQ(2, integer_value);
417 EXPECT_TRUE(dict_val->GetIntegerWithoutPathExpansion("a.b", &integer_value));
418 EXPECT_EQ(1, integer_value);
419
420 // Invalid, no closing brace
421 root.reset(JSONReader::DeprecatedRead("{\"a\": true"));
422 EXPECT_FALSE(root.get());
423
424 // Invalid, keys must be quoted
425 root.reset(JSONReader::DeprecatedRead("{foo:true}"));
426 EXPECT_FALSE(root.get());
427
428 // Invalid, trailing comma
429 root.reset(JSONReader::DeprecatedRead("{\"a\":true,}"));
430 EXPECT_FALSE(root.get());
431
432 // Invalid, too many commas
433 root.reset(JSONReader::DeprecatedRead("{\"a\":true,,\"b\":false}"));
434 EXPECT_FALSE(root.get());
435 root.reset(JSONReader::DeprecatedRead("{\"a\":true,,\"b\":false}",
436 JSON_ALLOW_TRAILING_COMMAS));
437 EXPECT_FALSE(root.get());
438
439 // Invalid, no separator
440 root.reset(JSONReader::DeprecatedRead("{\"a\" \"b\"}"));
441 EXPECT_FALSE(root.get());
442
443 // Invalid, lone comma.
444 root.reset(JSONReader::DeprecatedRead("{,}"));
445 EXPECT_FALSE(root.get());
446 root.reset(JSONReader::DeprecatedRead("{,}", JSON_ALLOW_TRAILING_COMMAS));
447 EXPECT_FALSE(root.get());
448 root.reset(
449 JSONReader::DeprecatedRead("{\"a\":true,,}", JSON_ALLOW_TRAILING_COMMAS));
450 EXPECT_FALSE(root.get());
451 root.reset(
452 JSONReader::DeprecatedRead("{,\"a\":true}", JSON_ALLOW_TRAILING_COMMAS));
453 EXPECT_FALSE(root.get());
454 root.reset(JSONReader::DeprecatedRead("{\"a\":true,,\"b\":false}",
455 JSON_ALLOW_TRAILING_COMMAS));
456 EXPECT_FALSE(root.get());
457
458 // Test stack overflow
459 std::string evil(1000000, '[');
460 evil.append(std::string(1000000, ']'));
461 root.reset(JSONReader::DeprecatedRead(evil));
462 EXPECT_FALSE(root.get());
463
464 // A few thousand adjacent lists is fine.
465 std::string not_evil("[");
466 not_evil.reserve(15010);
467 for (int i = 0; i < 5000; ++i) {
468 not_evil.append("[],");
469 }
470 not_evil.append("[]]");
471 root.reset(JSONReader::DeprecatedRead(not_evil));
472 ASSERT_TRUE(root.get());
473 EXPECT_TRUE(root->IsType(Value::TYPE_LIST));
474 list = static_cast<ListValue*>(root.get());
475 EXPECT_EQ(5001U, list->GetSize());
476
477 // Test utf8 encoded input
478 root = JSONReader().ReadToValue("\"\xe7\xbd\x91\xe9\xa1\xb5\"");
479 ASSERT_TRUE(root.get());
480 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
481 str_val.clear();
482 EXPECT_TRUE(root->GetAsString(&str_val));
Vitaly Buka8750b272015-08-18 18:39:08 -0700483 EXPECT_EQ("\xE7\xBD\x91\xE9\xA1\xB5", str_val);
Vitaly Bukacbed2062015-08-17 12:54:05 -0700484
485 root = JSONReader().ReadToValue(
486 "{\"path\": \"/tmp/\xc3\xa0\xc3\xa8\xc3\xb2.png\"}");
487 ASSERT_TRUE(root.get());
488 EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));
489 EXPECT_TRUE(root->GetAsDictionary(&dict_val));
490 EXPECT_TRUE(dict_val->GetString("path", &str_val));
491 EXPECT_EQ("/tmp/\xC3\xA0\xC3\xA8\xC3\xB2.png", str_val);
492
493 // Test invalid utf8 encoded input
494 root = JSONReader().ReadToValue("\"345\xb0\xa1\xb0\xa2\"");
495 EXPECT_FALSE(root.get());
496 root = JSONReader().ReadToValue("\"123\xc0\x81\"");
497 EXPECT_FALSE(root.get());
498 root = JSONReader().ReadToValue("\"abc\xc0\xae\"");
499 EXPECT_FALSE(root.get());
500
501 // Test utf16 encoded strings.
502 root = JSONReader().ReadToValue("\"\\u20ac3,14\"");
503 ASSERT_TRUE(root.get());
504 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
505 str_val.clear();
506 EXPECT_TRUE(root->GetAsString(&str_val));
507 EXPECT_EQ("\xe2\x82\xac""3,14", str_val);
508
509 root = JSONReader().ReadToValue("\"\\ud83d\\udca9\\ud83d\\udc6c\"");
510 ASSERT_TRUE(root.get());
511 EXPECT_TRUE(root->IsType(Value::TYPE_STRING));
512 str_val.clear();
513 EXPECT_TRUE(root->GetAsString(&str_val));
514 EXPECT_EQ("\xf0\x9f\x92\xa9\xf0\x9f\x91\xac", str_val);
515
516 // Test invalid utf16 strings.
517 const char* const cases[] = {
518 "\"\\u123\"", // Invalid scalar.
519 "\"\\ud83d\"", // Invalid scalar.
520 "\"\\u$%@!\"", // Invalid scalar.
521 "\"\\uzz89\"", // Invalid scalar.
522 "\"\\ud83d\\udca\"", // Invalid lower surrogate.
523 "\"\\ud83d\\ud83d\"", // Invalid lower surrogate.
524 "\"\\ud83foo\"", // No lower surrogate.
525 "\"\\ud83\\foo\"" // No lower surrogate.
526 };
527 for (size_t i = 0; i < arraysize(cases); ++i) {
528 root = JSONReader().ReadToValue(cases[i]);
529 EXPECT_FALSE(root.get()) << cases[i];
530 }
531
532 // Test literal root objects.
533 root.reset(JSONReader::DeprecatedRead("null"));
534 EXPECT_TRUE(root->IsType(Value::TYPE_NULL));
535
536 root.reset(JSONReader::DeprecatedRead("true"));
537 ASSERT_TRUE(root.get());
538 EXPECT_TRUE(root->GetAsBoolean(&bool_value));
539 EXPECT_TRUE(bool_value);
540
541 root.reset(JSONReader::DeprecatedRead("10"));
542 ASSERT_TRUE(root.get());
543 EXPECT_TRUE(root->GetAsInteger(&integer_value));
544 EXPECT_EQ(10, integer_value);
545
546 root.reset(JSONReader::DeprecatedRead("\"root\""));
547 ASSERT_TRUE(root.get());
548 EXPECT_TRUE(root->GetAsString(&str_val));
549 EXPECT_EQ("root", str_val);
550}
551
Vitaly Bukacbed2062015-08-17 12:54:05 -0700552// Tests that the root of a JSON object can be deleted safely while its
553// children outlive it.
554TEST(JSONReaderTest, StringOptimizations) {
555 scoped_ptr<Value> dict_literal_0;
556 scoped_ptr<Value> dict_literal_1;
557 scoped_ptr<Value> dict_string_0;
558 scoped_ptr<Value> dict_string_1;
559 scoped_ptr<Value> list_value_0;
560 scoped_ptr<Value> list_value_1;
561
562 {
563 scoped_ptr<Value> root = JSONReader::Read(
564 "{"
565 " \"test\": {"
566 " \"foo\": true,"
567 " \"bar\": 3.14,"
568 " \"baz\": \"bat\","
569 " \"moo\": \"cow\""
570 " },"
571 " \"list\": ["
572 " \"a\","
573 " \"b\""
574 " ]"
575 "}",
576 JSON_DETACHABLE_CHILDREN);
577 ASSERT_TRUE(root.get());
578
579 DictionaryValue* root_dict = NULL;
580 ASSERT_TRUE(root->GetAsDictionary(&root_dict));
581
582 DictionaryValue* dict = NULL;
583 ListValue* list = NULL;
584
585 ASSERT_TRUE(root_dict->GetDictionary("test", &dict));
586 ASSERT_TRUE(root_dict->GetList("list", &list));
587
588 EXPECT_TRUE(dict->Remove("foo", &dict_literal_0));
589 EXPECT_TRUE(dict->Remove("bar", &dict_literal_1));
590 EXPECT_TRUE(dict->Remove("baz", &dict_string_0));
591 EXPECT_TRUE(dict->Remove("moo", &dict_string_1));
592
593 ASSERT_EQ(2u, list->GetSize());
594 EXPECT_TRUE(list->Remove(0, &list_value_0));
595 EXPECT_TRUE(list->Remove(0, &list_value_1));
596 }
597
598 bool b = false;
599 double d = 0;
600 std::string s;
601
602 EXPECT_TRUE(dict_literal_0->GetAsBoolean(&b));
603 EXPECT_TRUE(b);
604
605 EXPECT_TRUE(dict_literal_1->GetAsDouble(&d));
606 EXPECT_EQ(3.14, d);
607
608 EXPECT_TRUE(dict_string_0->GetAsString(&s));
609 EXPECT_EQ("bat", s);
610
611 EXPECT_TRUE(dict_string_1->GetAsString(&s));
612 EXPECT_EQ("cow", s);
613
614 EXPECT_TRUE(list_value_0->GetAsString(&s));
615 EXPECT_EQ("a", s);
616 EXPECT_TRUE(list_value_1->GetAsString(&s));
617 EXPECT_EQ("b", s);
618}
619
620// A smattering of invalid JSON designed to test specific portions of the
621// parser implementation against buffer overflow. Best run with DCHECKs so
622// that the one in NextChar fires.
623TEST(JSONReaderTest, InvalidSanity) {
624 const char* const invalid_json[] = {
625 "/* test *",
626 "{\"foo\"",
627 "{\"foo\":",
628 " [",
629 "\"\\u123g\"",
630 "{\n\"eh:\n}",
631 };
632
633 for (size_t i = 0; i < arraysize(invalid_json); ++i) {
634 JSONReader reader;
635 LOG(INFO) << "Sanity test " << i << ": <" << invalid_json[i] << ">";
636 EXPECT_FALSE(reader.ReadToValue(invalid_json[i]));
637 EXPECT_NE(JSONReader::JSON_NO_ERROR, reader.error_code());
638 EXPECT_NE("", reader.GetErrorMessage());
639 }
640}
641
642TEST(JSONReaderTest, IllegalTrailingNull) {
643 const char json[] = { '"', 'n', 'u', 'l', 'l', '"', '\0' };
644 std::string json_string(json, sizeof(json));
645 JSONReader reader;
646 EXPECT_FALSE(reader.ReadToValue(json_string));
647 EXPECT_EQ(JSONReader::JSON_UNEXPECTED_DATA_AFTER_ROOT, reader.error_code());
648}
649
650} // namespace base