Vitaly Buka | 4615e0d | 2015-10-14 15:35:12 -0700 | [diff] [blame] | 1 | // Copyright 2015 The Weave Authors. All rights reserved. |
Alex Vakulenko | 7c36b67 | 2014-07-16 14:50:58 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Stefan Sauer | 2d16dfa | 2015-09-25 17:08:35 +0200 | [diff] [blame] | 5 | #include "src/commands/command_manager.h" |
Alex Deymo | f6cbe32 | 2014-11-10 19:55:35 -0800 | [diff] [blame] | 6 | |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 7 | #include <map> |
| 8 | |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 9 | #include <base/json/json_writer.h> |
Alex Vakulenko | 7c36b67 | 2014-07-16 14:50:58 -0700 | [diff] [blame] | 10 | #include <gtest/gtest.h> |
Vitaly Buka | 1e36367 | 2015-09-25 14:01:16 -0700 | [diff] [blame] | 11 | #include <weave/provider/test/mock_config_store.h> |
Alex Vakulenko | 7c36b67 | 2014-07-16 14:50:58 -0700 | [diff] [blame] | 12 | |
Stefan Sauer | 2d16dfa | 2015-09-25 17:08:35 +0200 | [diff] [blame] | 13 | #include "src/bind_lambda.h" |
| 14 | #include "src/commands/unittest_utils.h" |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 15 | |
Vitaly Buka | 11b2f23 | 2015-08-20 13:55:41 -0700 | [diff] [blame] | 16 | using testing::Return; |
| 17 | |
Vitaly Buka | b6f015a | 2015-07-09 14:59:23 -0700 | [diff] [blame] | 18 | namespace weave { |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 19 | |
Vitaly Buka | 0f6b2ec | 2015-08-20 15:35:19 -0700 | [diff] [blame] | 20 | using test::CreateDictionaryValue; |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 21 | |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 22 | namespace { |
| 23 | |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 24 | const char kTestVendorCommands[] = R"({ |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 25 | "robot": { |
| 26 | "_jump": { |
| 27 | "parameters": {"height": "integer"}, |
| 28 | "results": {} |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 29 | }, |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 30 | "_speak": { |
| 31 | "parameters": {"phrase": "string"}, |
| 32 | "results": {} |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 33 | } |
| 34 | } |
| 35 | })"; |
| 36 | |
| 37 | const char kTestTestCommands[] = R"({ |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 38 | "test": { |
| 39 | "_yo": { |
| 40 | "parameters": {"name": "string"}, |
| 41 | "results": {} |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 42 | } |
| 43 | } |
| 44 | })"; |
| 45 | |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 46 | } // namespace |
| 47 | |
Alex Vakulenko | 7c36b67 | 2014-07-16 14:50:58 -0700 | [diff] [blame] | 48 | TEST(CommandManager, Empty) { |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 49 | CommandManager manager; |
Alex Vakulenko | 7c36b67 | 2014-07-16 14:50:58 -0700 | [diff] [blame] | 50 | EXPECT_TRUE(manager.GetCommandDictionary().IsEmpty()); |
| 51 | } |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 52 | |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 53 | TEST(CommandManager, LoadCommandsDict) { |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 54 | CommandManager manager; |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 55 | auto json = CreateDictionaryValue(kTestVendorCommands); |
Vitaly Buka | 453c4dd | 2015-10-04 18:01:50 -0700 | [diff] [blame] | 56 | EXPECT_TRUE(manager.LoadCommands(*json, nullptr)); |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 57 | } |
| 58 | |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 59 | TEST(CommandManager, LoadCommandsJson) { |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 60 | CommandManager manager; |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 61 | |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 62 | // Load device-supported commands. |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 63 | auto json_str = R"({ |
| 64 | "base": { |
| 65 | "reboot": { |
| 66 | "parameters": {"delay": "integer"}, |
| 67 | "results": {} |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 68 | } |
| 69 | }, |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 70 | "robot": { |
| 71 | "_jump": { |
| 72 | "parameters": {"height": "integer"}, |
| 73 | "results": {} |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 74 | } |
| 75 | } |
Vitaly Buka | e2810e0 | 2015-08-16 23:31:55 -0700 | [diff] [blame] | 76 | })"; |
Vitaly Buka | 453c4dd | 2015-10-04 18:01:50 -0700 | [diff] [blame] | 77 | EXPECT_TRUE(manager.LoadCommands(json_str, nullptr)); |
Alex Vakulenko | fd44869 | 2014-07-22 07:46:53 -0700 | [diff] [blame] | 78 | EXPECT_EQ(2, manager.GetCommandDictionary().GetSize()); |
| 79 | EXPECT_NE(nullptr, manager.GetCommandDictionary().FindCommand("base.reboot")); |
| 80 | EXPECT_NE(nullptr, manager.GetCommandDictionary().FindCommand("robot._jump")); |
| 81 | } |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 82 | |
| 83 | TEST(CommandManager, ShouldLoadStandardAndTestDefinitions) { |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 84 | CommandManager manager; |
Vitaly Buka | 0ac6ca6 | 2015-10-06 19:16:29 -0700 | [diff] [blame] | 85 | ASSERT_TRUE(manager.LoadCommands(kTestVendorCommands, nullptr)); |
| 86 | ASSERT_TRUE(manager.LoadCommands(kTestTestCommands, nullptr)); |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 87 | EXPECT_EQ(3, manager.GetCommandDictionary().GetSize()); |
Vitaly Buka | a647c85 | 2015-07-06 14:51:01 -0700 | [diff] [blame] | 88 | EXPECT_NE(nullptr, manager.GetCommandDictionary().FindCommand("robot._jump")); |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 89 | EXPECT_NE(nullptr, |
| 90 | manager.GetCommandDictionary().FindCommand("robot._speak")); |
Vitaly Buka | a647c85 | 2015-07-06 14:51:01 -0700 | [diff] [blame] | 91 | EXPECT_NE(nullptr, manager.GetCommandDictionary().FindCommand("test._yo")); |
Christopher Wiley | bb5b848 | 2015-02-12 13:42:16 -0800 | [diff] [blame] | 92 | } |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 93 | |
| 94 | TEST(CommandManager, UpdateCommandVisibility) { |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 95 | CommandManager manager; |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 96 | int update_count = 0; |
| 97 | auto on_command_change = [&update_count]() { update_count++; }; |
Vitaly Buka | 553a762 | 2015-10-05 13:53:20 -0700 | [diff] [blame] | 98 | manager.AddCommandDefChanged(base::Bind(on_command_change)); |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 99 | |
| 100 | auto json = CreateDictionaryValue(R"({ |
| 101 | 'foo': { |
| 102 | '_baz': { |
| 103 | 'parameters': {}, |
| 104 | 'results': {} |
| 105 | }, |
| 106 | '_bar': { |
| 107 | 'parameters': {}, |
| 108 | 'results': {} |
| 109 | } |
| 110 | }, |
| 111 | 'bar': { |
| 112 | '_quux': { |
| 113 | 'parameters': {}, |
| 114 | 'results': {}, |
| 115 | 'visibility': 'none' |
| 116 | } |
| 117 | } |
| 118 | })"); |
Vitaly Buka | 453c4dd | 2015-10-04 18:01:50 -0700 | [diff] [blame] | 119 | ASSERT_TRUE(manager.LoadCommands(*json, nullptr)); |
Vitaly Buka | 7ab89ff | 2015-06-09 22:11:40 -0700 | [diff] [blame] | 120 | EXPECT_EQ(2, update_count); |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 121 | const CommandDictionary& dict = manager.GetCommandDictionary(); |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 122 | EXPECT_TRUE(manager.SetCommandVisibility( |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 123 | {"foo._baz"}, CommandDefinition::Visibility::GetLocal(), nullptr)); |
Vitaly Buka | 7ab89ff | 2015-06-09 22:11:40 -0700 | [diff] [blame] | 124 | EXPECT_EQ(3, update_count); |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 125 | EXPECT_EQ("local", dict.FindCommand("foo._baz")->GetVisibility().ToString()); |
| 126 | EXPECT_EQ("all", dict.FindCommand("foo._bar")->GetVisibility().ToString()); |
| 127 | EXPECT_EQ("none", dict.FindCommand("bar._quux")->GetVisibility().ToString()); |
| 128 | |
Vitaly Buka | 0801a1f | 2015-08-14 10:03:46 -0700 | [diff] [blame] | 129 | ErrorPtr error; |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 130 | ASSERT_FALSE(manager.SetCommandVisibility( |
| 131 | {"foo._baz", "foo._bar", "test.cmd"}, |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 132 | CommandDefinition::Visibility::GetLocal(), &error)); |
| 133 | EXPECT_EQ(errors::commands::kInvalidCommandName, error->GetCode()); |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 134 | // The visibility state of commands shouldn't have changed. |
Vitaly Buka | 7ab89ff | 2015-06-09 22:11:40 -0700 | [diff] [blame] | 135 | EXPECT_EQ(3, update_count); |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 136 | EXPECT_EQ("local", dict.FindCommand("foo._baz")->GetVisibility().ToString()); |
| 137 | EXPECT_EQ("all", dict.FindCommand("foo._bar")->GetVisibility().ToString()); |
| 138 | EXPECT_EQ("none", dict.FindCommand("bar._quux")->GetVisibility().ToString()); |
| 139 | |
| 140 | EXPECT_TRUE(manager.SetCommandVisibility( |
Vitaly Buka | 32005de | 2015-05-01 12:33:31 -0700 | [diff] [blame] | 141 | {"foo._baz", "bar._quux"}, CommandDefinition::Visibility::GetCloud(), |
| 142 | nullptr)); |
Vitaly Buka | 7ab89ff | 2015-06-09 22:11:40 -0700 | [diff] [blame] | 143 | EXPECT_EQ(4, update_count); |
Alex Vakulenko | e03af6d | 2015-04-20 11:00:54 -0700 | [diff] [blame] | 144 | EXPECT_EQ("cloud", dict.FindCommand("foo._baz")->GetVisibility().ToString()); |
| 145 | EXPECT_EQ("all", dict.FindCommand("foo._bar")->GetVisibility().ToString()); |
| 146 | EXPECT_EQ("cloud", dict.FindCommand("bar._quux")->GetVisibility().ToString()); |
| 147 | } |
| 148 | |
Vitaly Buka | b6f015a | 2015-07-09 14:59:23 -0700 | [diff] [blame] | 149 | } // namespace weave |