Vitaly Buka | 4615e0d | 2015-10-14 15:35:12 -0700 | [diff] [blame] | 1 | // Copyright 2015 The Weave Authors. All rights reserved. |
Alex Vakulenko | aa3a559 | 2014-08-07 07:24:06 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Stefan Sauer | 2d16dfa | 2015-09-25 17:08:35 +0200 | [diff] [blame] | 5 | #include "src/commands/command_instance.h" |
Alex Deymo | f6cbe32 | 2014-11-10 19:55:35 -0800 | [diff] [blame] | 6 | |
Alex Vakulenko | aa3a559 | 2014-08-07 07:24:06 -0700 | [diff] [blame] | 7 | #include <gtest/gtest.h> |
Alex Vakulenko | 8a05beb | 2015-11-24 17:13:20 -0800 | [diff] [blame] | 8 | #include <weave/test/unittest_utils.h> |
Alex Vakulenko | aa3a559 | 2014-08-07 07:24:06 -0700 | [diff] [blame] | 9 | |
Vitaly Buka | b6f015a | 2015-07-09 14:59:23 -0700 | [diff] [blame] | 10 | namespace weave { |
Vitaly Buka | 5f0d1d0 | 2015-04-29 11:39:55 -0700 | [diff] [blame] | 11 | |
Vitaly Buka | 0f6b2ec | 2015-08-20 15:35:19 -0700 | [diff] [blame] | 12 | using test::CreateDictionaryValue; |
| 13 | using test::CreateValue; |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 14 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 15 | TEST(CommandInstanceTest, Test) { |
Alex Vakulenko | 36bf1b5 | 2015-11-23 09:35:37 -0800 | [diff] [blame] | 16 | auto params = CreateDictionaryValue(R"({ |
| 17 | 'phrase': 'iPityDaFool', |
| 18 | 'volume': 5 |
| 19 | })"); |
Alex Vakulenko | 2c7740a | 2015-11-30 08:51:29 -0800 | [diff] [blame] | 20 | CommandInstance instance{"robot.speak", Command::Origin::kCloud, *params}; |
Anton Muhin | cfde869 | 2014-11-25 03:36:59 +0400 | [diff] [blame] | 21 | |
Vitaly Buka | 4f4e228 | 2015-07-23 17:50:07 -0700 | [diff] [blame] | 22 | EXPECT_TRUE( |
Vitaly Buka | 2f54897 | 2015-10-08 19:34:49 -0700 | [diff] [blame] | 23 | instance.Complete(*CreateDictionaryValue("{'foo': 239}"), nullptr)); |
Alex Vakulenko | aa3a559 | 2014-08-07 07:24:06 -0700 | [diff] [blame] | 24 | |
Alex Vakulenko | fedc487 | 2014-08-20 12:38:43 -0700 | [diff] [blame] | 25 | EXPECT_EQ("", instance.GetID()); |
Anton Muhin | cfde869 | 2014-11-25 03:36:59 +0400 | [diff] [blame] | 26 | EXPECT_EQ("robot.speak", instance.GetName()); |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 27 | EXPECT_EQ(Command::Origin::kCloud, instance.GetOrigin()); |
Vitaly Buka | 8d8d219 | 2015-07-21 22:25:09 -0700 | [diff] [blame] | 28 | EXPECT_JSON_EQ("{'phrase': 'iPityDaFool', 'volume': 5}", |
Vitaly Buka | c430560 | 2015-11-24 23:33:09 -0800 | [diff] [blame] | 29 | instance.GetParameters()); |
| 30 | EXPECT_JSON_EQ("{'foo': 239}", instance.GetResults()); |
Alex Vakulenko | f784e21 | 2015-04-20 12:33:52 -0700 | [diff] [blame] | 31 | |
Alex Vakulenko | 2c7740a | 2015-11-30 08:51:29 -0800 | [diff] [blame] | 32 | CommandInstance instance2{"base.reboot", Command::Origin::kLocal, {}}; |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 33 | EXPECT_EQ(Command::Origin::kLocal, instance2.GetOrigin()); |
Alex Vakulenko | aa3a559 | 2014-08-07 07:24:06 -0700 | [diff] [blame] | 34 | } |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 35 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 36 | TEST(CommandInstanceTest, SetID) { |
Alex Vakulenko | 2c7740a | 2015-11-30 08:51:29 -0800 | [diff] [blame] | 37 | CommandInstance instance{"base.reboot", Command::Origin::kLocal, {}}; |
Alex Vakulenko | fedc487 | 2014-08-20 12:38:43 -0700 | [diff] [blame] | 38 | instance.SetID("command_id"); |
| 39 | EXPECT_EQ("command_id", instance.GetID()); |
| 40 | } |
| 41 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 42 | TEST(CommandInstanceTest, FromJson) { |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 43 | auto json = CreateDictionaryValue(R"({ |
| 44 | 'name': 'robot.jump', |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 45 | 'component': 'comp1.comp2', |
Alex Vakulenko | d1978d3 | 2015-04-29 17:33:26 -0700 | [diff] [blame] | 46 | 'id': 'abcd', |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 47 | 'parameters': { |
| 48 | 'height': 53, |
| 49 | '_jumpType': '_withKick' |
Anton Muhin | 71fb9d5 | 2014-11-21 22:22:39 +0400 | [diff] [blame] | 50 | }, |
| 51 | 'results': {} |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 52 | })"); |
Alex Vakulenko | d1978d3 | 2015-04-29 17:33:26 -0700 | [diff] [blame] | 53 | std::string id; |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 54 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 55 | &id, nullptr); |
Alex Vakulenko | d1978d3 | 2015-04-29 17:33:26 -0700 | [diff] [blame] | 56 | EXPECT_EQ("abcd", id); |
| 57 | EXPECT_EQ("abcd", instance->GetID()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 58 | EXPECT_EQ("robot.jump", instance->GetName()); |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 59 | EXPECT_EQ("comp1.comp2", instance->GetComponent()); |
Vitaly Buka | 8d8d219 | 2015-07-21 22:25:09 -0700 | [diff] [blame] | 60 | EXPECT_JSON_EQ("{'height': 53, '_jumpType': '_withKick'}", |
Vitaly Buka | c430560 | 2015-11-24 23:33:09 -0800 | [diff] [blame] | 61 | instance->GetParameters()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 62 | } |
| 63 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 64 | TEST(CommandInstanceTest, FromJson_ParamsOmitted) { |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 65 | auto json = CreateDictionaryValue("{'name': 'base.reboot'}"); |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 66 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 67 | nullptr, nullptr); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 68 | EXPECT_EQ("base.reboot", instance->GetName()); |
Vitaly Buka | c430560 | 2015-11-24 23:33:09 -0800 | [diff] [blame] | 69 | EXPECT_JSON_EQ("{}", instance->GetParameters()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 70 | } |
| 71 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 72 | TEST(CommandInstanceTest, FromJson_NotObject) { |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 73 | auto json = CreateValue("'string'"); |
Vitaly Buka | 0801a1f | 2015-08-14 10:03:46 -0700 | [diff] [blame] | 74 | ErrorPtr error; |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 75 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 76 | nullptr, &error); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 77 | EXPECT_EQ(nullptr, instance.get()); |
| 78 | EXPECT_EQ("json_object_expected", error->GetCode()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 79 | } |
| 80 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 81 | TEST(CommandInstanceTest, FromJson_NameMissing) { |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 82 | auto json = CreateDictionaryValue("{'param': 'value'}"); |
Vitaly Buka | 0801a1f | 2015-08-14 10:03:46 -0700 | [diff] [blame] | 83 | ErrorPtr error; |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 84 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 85 | nullptr, &error); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 86 | EXPECT_EQ(nullptr, instance.get()); |
| 87 | EXPECT_EQ("parameter_missing", error->GetCode()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 88 | } |
| 89 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 90 | TEST(CommandInstanceTest, FromJson_ParamsNotObject) { |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 91 | auto json = CreateDictionaryValue(R"({ |
| 92 | 'name': 'robot.speak', |
| 93 | 'parameters': 'hello' |
| 94 | })"); |
Vitaly Buka | 0801a1f | 2015-08-14 10:03:46 -0700 | [diff] [blame] | 95 | ErrorPtr error; |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 96 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 97 | nullptr, &error); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 98 | EXPECT_EQ(nullptr, instance.get()); |
| 99 | auto inner = error->GetInnerError(); |
| 100 | EXPECT_EQ("json_object_expected", inner->GetCode()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 101 | EXPECT_EQ("command_failed", error->GetCode()); |
Alex Vakulenko | 8dc69af | 2014-08-07 10:29:42 -0700 | [diff] [blame] | 102 | } |
| 103 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 104 | TEST(CommandInstanceTest, ToJson) { |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 105 | auto json = CreateDictionaryValue(R"({ |
Vitaly Buka | 5ddd991 | 2016-03-09 10:44:48 -0800 | [diff] [blame] | 106 | 'component': 'testComponent', |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 107 | 'name': 'robot.jump', |
| 108 | 'parameters': { |
| 109 | 'height': 53, |
| 110 | '_jumpType': '_withKick' |
| 111 | }, |
| 112 | 'results': {} |
| 113 | })"); |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 114 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 115 | nullptr, nullptr); |
Vitaly Buka | 4f4e228 | 2015-07-23 17:50:07 -0700 | [diff] [blame] | 116 | EXPECT_TRUE(instance->SetProgress(*CreateDictionaryValue("{'progress': 15}"), |
| 117 | nullptr)); |
| 118 | EXPECT_TRUE(instance->SetProgress(*CreateDictionaryValue("{'progress': 15}"), |
| 119 | nullptr)); |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 120 | instance->SetID("testId"); |
Vitaly Buka | 2f54897 | 2015-10-08 19:34:49 -0700 | [diff] [blame] | 121 | EXPECT_TRUE(instance->Complete(*CreateDictionaryValue("{'testResult': 17}"), |
| 122 | nullptr)); |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 123 | |
| 124 | json->MergeDictionary(CreateDictionaryValue(R"({ |
Vitaly Buka | 5ddd991 | 2016-03-09 10:44:48 -0800 | [diff] [blame] | 125 | 'component': 'testComponent', |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 126 | 'id': 'testId', |
Alex Vakulenko | 808e2d8 | 2015-04-08 15:45:56 -0700 | [diff] [blame] | 127 | 'progress': {'progress': 15}, |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 128 | 'state': 'done', |
| 129 | 'results': {'testResult': 17} |
| 130 | })").get()); |
| 131 | |
| 132 | auto converted = instance->ToJson(); |
| 133 | EXPECT_PRED2([](const base::Value& val1, |
| 134 | const base::Value& val2) { return val1.Equals(&val2); }, |
| 135 | *json, *converted); |
| 136 | } |
| 137 | |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 138 | TEST(CommandInstanceTest, ToJsonError) { |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 139 | auto json = CreateDictionaryValue(R"({ |
Vitaly Buka | 5ddd991 | 2016-03-09 10:44:48 -0800 | [diff] [blame] | 140 | 'component': 'testComponent', |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 141 | 'name': 'base.reboot', |
| 142 | 'parameters': {} |
| 143 | })"); |
Vitaly Buka | 0209da4 | 2015-10-08 00:07:18 -0700 | [diff] [blame] | 144 | auto instance = CommandInstance::FromJson(json.get(), Command::Origin::kCloud, |
Alex Vakulenko | 88f55d8 | 2015-12-03 15:30:27 -0800 | [diff] [blame] | 145 | nullptr, nullptr); |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 146 | instance->SetID("testId"); |
| 147 | |
| 148 | ErrorPtr error; |
Vitaly Buka | 48a8669 | 2016-01-21 17:15:58 -0800 | [diff] [blame] | 149 | Error::AddTo(&error, FROM_HERE, "CODE", "MESSAGE"); |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 150 | instance->Abort(error.get(), nullptr); |
| 151 | |
| 152 | json->MergeDictionary(CreateDictionaryValue(R"({ |
Vitaly Buka | 5ddd991 | 2016-03-09 10:44:48 -0800 | [diff] [blame] | 153 | 'component': 'testComponent', |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 154 | 'id': 'testId', |
Vitaly Buka | 70f77d9 | 2015-10-07 15:42:40 -0700 | [diff] [blame] | 155 | 'state': 'aborted', |
Vitaly Buka | 47a1f6f | 2015-10-07 18:09:57 -0700 | [diff] [blame] | 156 | 'progress': {}, |
| 157 | 'results': {}, |
Vitaly Buka | 70f77d9 | 2015-10-07 15:42:40 -0700 | [diff] [blame] | 158 | 'error': {'code': 'CODE', 'message': 'MESSAGE'} |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 159 | })").get()); |
| 160 | |
| 161 | auto converted = instance->ToJson(); |
Vitaly Buka | 4ebd329 | 2015-09-23 18:04:17 -0700 | [diff] [blame] | 162 | EXPECT_PRED2([](const base::Value& val1, |
| 163 | const base::Value& val2) { return val1.Equals(&val2); }, |
| 164 | *json, *converted); |
Vitaly Buka | 906d39e | 2015-03-24 10:08:26 -0700 | [diff] [blame] | 165 | } |
Vitaly Buka | 5f0d1d0 | 2015-04-29 11:39:55 -0700 | [diff] [blame] | 166 | |
Vitaly Buka | b6f015a | 2015-07-09 14:59:23 -0700 | [diff] [blame] | 167 | } // namespace weave |